[Dltk-dev] Re: Regarding bug https://bugs.eclipse.org/bugs/show_bug.cgi?

[Alex Panchenko <alex@xxxxxxxxx>]

Hi Gabriel,

I have corrected processing of nested library elements - path passed to LibraryLocation constructor should have environmentId.

Answers:
- home attribute should point to the executable file
- library path is expected to be relative, e.g. ../modules
- "BASEPATH\interpreter.exe\..\modules" is correctly resolved to "BASEPATH\modules"

Regards,
Alex

----- Original Message -----
From: "Gabriel Petrovay" <gabriel.petrovay@xxxxxxxxxx>
To: alex@xxxxxxxxx, "dltk-dev" <dltk-dev@xxxxxxxxxxx>
Sent: Friday, April 17, 2009 2:27:51 PM GMT +06:00 Almaty, Novosibirsk
Subject: Regarding bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=272268

Hi Alex,

This is regardin your resolution for bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=272268

Description here:
http://dev.eclipse.org/mhonarc/lists/dltk-dev/msg01495.html


Here is my problem:
I want to ship the plugin with an already configured
InterpreterInstall. (This is shipped in a plugin fragment bundle) For
this I use the org.eclipse.dltk.launching.interpreterInstalls
extension point?

What should I write in the "home" attribute? (waiting for an answer from you).


CASE 1:
If I provide here the executable, the logic of finding the libraries
is broken because ScriptRuntime.addInterpreterExtensions() APPENDS the
libPathStr to the libPath variable which reflect the value set in the
"home" attribute. Example:
home="C:\MyInterpreter\interpreter.exe"
for library node:
path="..\modules"
=> libPath = "C:\MyInterpreter\interpreter.exe\..\modules" which is wrong.


CASE 2:
If I stick to your documentation and provide a directory in the "home"
attribute, the validation of a installType location is not uniform:
installType.validateInstallLocation(homeDir);
In this case a directory is passed to the validateInstallLocation()
method, while in the UI (AddScriptInterpreterDialog), a file is
validated after the Browse action. Tcl and Ruby fail validation if the
provided IFileHandler points to a directory. This makes the
implementation not uniform.

Tell me please what do I see wrong here? (besides the whole image :) )

Thanks!
Gabriel

-- 
MSc Gabriel Petrovay
MCSA, MCDBA, MCAD
Mobile: +41(0)787978034