Re: [Dltk-dev] NPE on deleting launch configuration

[Alex Panchenko <alex@xxxxxxxxx>]

Hi Gerald,

Null checks were already present in HEAD (1.0), now I have ported them to the 0.95 branch.
So this fix will be included in the DLTK 0.95.2

Thanks,
Alex

----- Original Message -----
From: "Gerald Rosenberg" <gerald@xxxxxxxxxx>
To: dltk-dev@xxxxxxxxxxx
Sent: Thursday, January 8, 2009 11:54:02 AM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] NPE on deleting launch configuration


Using Eclipse 3.4.1 and DLTK 0.95.1 

Possible bug: 

I am deleting a launch configuration: 

for (ILaunchConfiguration config : manager.getLaunchConfigurations(type)) { 
if (config.getName().equals(unit.getLaunchName())) { 
config.delete(); 
break ; 
} 
} 

When the delete occurs, ScriptDebugLogManager#launchChanged winds up being called following from a LaunchManager$LaunchNotifier#run: 

public void launchChanged(ILaunch launch) { 
IDebugTarget target = launch.getDebugTarget(); 
boolean loggingEnabled = LaunchConfigurationUtils 
. isDbgpLoggingEnabled (launch.getLaunchConfiguration()); 

Both launch#getDebugTarget() and launch#getLaunchConfiguration() return null, as expected given deletion of the launch configuration, the latter call resulting in an NPE. 

Cannot quite figure out why ScriptDebugLogManager#launchChanged is being called in the first place. I would expect ScriptDebugLogManager#launchRemoved to be the correct method called. 

Is this a bug, or am I missing an override somewhere to force correct behavior? 

Thanks, 
Gerald 
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev