Re: [cdt-dev] Increasing PDOMCPPParameter.RECORD_SIZE to 23

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

On Tue, May 6, 2014 at 9:05 PM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:

PDOMCPPParameter.java contains the following below the declaration
of RECORD_SIZE:

    static {
        assert RECORD_SIZE <= 22; // 23 would yield a 32-byte block
    }

First, what does the comment mean? How does a 23-byte record yield
a 32-byte block?

23 + BLOCK_HEADER_SIZE(2) = 25 

After rounding up to a multiple of BLOCK_SIZE_DELTA(8) it yields 32.

Second, to fix bug 432701 [1], we need to store the default value
of a function parameter in the index. This would involve replacing
the 1-byte "flags" field with a 6-byte "value" field, which would
increase the size of the record to 23. Should I do that (and remove
the assertion), or is there something else I can do?

Current record size is 18. If the value is stored offline, with a pointer in PDOMCPPParameter, the record size will grow only to 21.

Thanks,
Nate

-sergey 

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=432701

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev