[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] Rx/Tx tracing patch
|
> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx
> [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Jason Litton
> Sent: Friday, May 18, 2012 12:51 PM
> To: CDT General developers list.
> Subject: [cdt-dev] Rx/Tx tracing patch
>
> I'm trying to work on fixing the patch for the RxTx tracing.
> I've added copyright to the files. Would you like me to add
> the extension points to plugin.xml and the plugin properties
> stuff, or should that be a separate patch?
I assumed you needed the plugin.xml parts to achieve your goal
of saving the traces to a file. If that is true, might as
well put everything as a single patch.
If you don't absolutely need the plugin.xml stuff to achieve
your goal then two separate patches is ok (but not necessary).
That means two Gerrit reviews and two bugzillas.
> Also, this is my
> first shot at using Git and Gerrit, and it's not going well,
> so I may have an ugly series of commits.
There should be only one commit for a Gerrit review. That
commit keeps getting updated with new changes.
To update an existing review, as you need to do, you should
modify your previous commit. To do that with Egit, you
simply start to commit your new changes, but in the
commit message dialog, click on the "Ammend Previous Commit"
toggle button, which is on the top-right.
This will automatically use the Gerrit changeId that was
used in the previous Gerrit review, which is how Gerrit
knows that this updated commit should go to the same review.
Feel free to ask more questions if you need to.
Marc
> Thanks,
> Jason
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
