Re: [cdt-dev] FYI, merged in a bunch of changes

[Chris Recoskie <recoskie@xxxxxxxxxx>]

Guys,

FileSystemUtilityManager and friends were introduced in the cdt_5_0 branch. You didn't complain then. Bugzillas exist with the previous incarnation of the API, which some of you commented upon (hence my change in this version to make the interfaces noimplement/noextend at Markus' suggestion). It doesn't make sense to complain about it now. We have been using and relying upon this API for a year now.

The API I added to ITranslation unit *is* after the freeze I admit, but since we have been so busy getting our product out the door until the last couple of weeks, we unfortunately didn't have a chance to try moving up to the Helios codebase until now, and lo and behold a whole bunch of stuff that worked fine with CDT 6 was now broken. If there's a better way to do that change that I did to ITranslationUnit then I'm entirely prepared to listen.

The API filter is probably old... from CDT 5.0.x. It may not be required any more.

I have a Dr's appointment this morning so I'll be away for the next few hours, but I'll try to get James some stack dumps this afternoon.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

Andrew Gvozdev ---05/12/2010 09:35:17 AM---What error do you see? Chris added API filter but I don't see any error even after removing the filt

From:	Andrew Gvozdev <angvoz.dev@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 09:35 AM
Subject:	Re: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

---

What error do you see? Chris added API filter but I don't see any error even after removing the filter and recompiling.

I looked at ErrorParserManager and the new FileSystemUtility classes and the first impression that it makes sense although I'd rather advocate the new API in next release at that point (unless there is a good reason). But it shouldn't have been added this way after M7 with no bugzilla, no discussion and no advance notification on cdt-dev.

Andrew

On Wed, May 12, 2010 at 8:58 AM, Marc Khouzam <marc.khouzam@xxxxxxxxxxxx> wrote:

IFilesystemUtility is giving an API tooling error.
I didn't fix it because it was not clear what you guys will do about this class.



---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Schorn, Markus
Sent: Wednesday, May 12, 2010 5:05 AM

To: CDT General developers list.
Subject: RE: [cdt-dev] FYI, merged in a bunch of changes

I agree. We should undo the change and open a bug to discuss the required change.
Markus.



---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Sergey Prigogin
Sent: Wednesday, May 12, 2010 3:51 AM
To: CDT General developers list.
Subject: Re: [cdt-dev] FYI, merged in a bunch of changes
Importance: Low

The descriptions of IFilesystemUtility methods seem too vague to really specify the behavior. Some terms, e.g. target machine, mapped filesystem, are used without being clearly defined. I'm against making this API change so late in the release cycle.

-sergey

On Tue, May 11, 2010 at 3:55 PM, Chris Recoskie <recoskie@xxxxxxxxxx> wrote:
- Merged changes from cdt_5_0 to HEAD. Too many to mention individually.
- Reworked IFileSystem utility so that now it is noimplement/noextend. Clients should now extend from concrete class FileSystemUtility instead to better insulate them from future API changes.
- Reworked the resulting concurrency fixes - indexing and scanner discovery now synchronize on the project root as a scheduling rule. Original HEAD behaviour was to synch on the project's .settings folder for indexing, but that deadlocked with scanner discovery. James, you will probably want to take a look at what I did there and make sure you are comfortable with it, as I know you have been trying to relax the scheduling rules as much as possible. If you think it needs some rework let me know.
- Fixed remote indexing. Changes on HEAD that deprecated CodeReader broke the ability for remote translation units to provide the path to load the file content from. Added API to ITranslationUnit for this purpose.

The tests all pass, but let me know if you run into any problems, particularly if you encounter any concurrency issues.

FYI error parsing seems broken for remote projects. I intend to start looking into that tomorrow.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev



_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev