Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] Fw: CDT/Debug Eclipse-3.0M6 compilation problems


Here is a patch for the ManagedBuilder ui.   (it works on M6 but not M5).

        - Dave





"Alain Magloire" <alain@xxxxxxx>
Sent by: cdt-dev-bounces@xxxxxxxxxxx

04/05/2005 10:40 AM

Please respond to
"CDT General developers list."

To
cdt-dev@xxxxxxxxxxx
cc
Subject
Re: [cdt-dev] Fw: CDT/Debug Eclipse-3.0M6 compilation problems





>
> cdt-dev-bounces@xxxxxxxxxxx wrote on 04/05/2005 10:12:15 AM:
>
> > >
> > > Uh, Alain, these changes just broke everyone in both M5 and M6...
> > >
> >
> > Broke M5 ... Yes.
> > Necessary, the API for the debugger Memory Model changed.
>
> I wasn't aware that we were ready to leave M5 yet. Certainly didn't see
> anything on the list asking if it was O.K.
>

sigh ...
Another mis-communication ... apologies.

Since everybody approved of the CDT-3.0 plan and milestone dates
                # Eclipse 3.1 M6 Apr 1,
                # 2005 CDT 3.0 M6 - Monday April 11, 2005 - stable build reflecting progress, APIs are documented

It was not clear to us why wait to move M6.

So what is the correct strategy for next time ?

> > Broke M6 ... ??  How ?
> > My current repository compiled file and run find except for managed
> builder
>
> That's a big except...
>

8-)
It's the use of NLS, it's in one file, I'll correct this in a moment.
Thanks.

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev

Index: src/org/eclipse/cdt/managedbuilder/ui/properties/BrowseEntryDialog.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BrowseEntryDialog.java,v
retrieving revision 1.5
diff -u -r1.5 BrowseEntryDialog.java
--- src/org/eclipse/cdt/managedbuilder/ui/properties/BrowseEntryDialog.java	19 May 2004 19:36:11 -0000	1.5
+++ src/org/eclipse/cdt/managedbuilder/ui/properties/BrowseEntryDialog.java	5 Apr 2005 14:52:50 -0000
@@ -48,9 +48,6 @@
 	private static final String PREFIX = "BuildPropertyCommon"; //$NON-NLS-1$
 	private static final String LABEL = PREFIX + ".label"; //$NON-NLS-1$
 	private static final String BROWSE = LABEL + ".browse"; //$NON-NLS-1$
-	private static final String HIDE = "hideAdvanced"; //$NON-NLS-1$
-	private static final String SHOW = "showAdvanced"; //$NON-NLS-1$
-	private static final String EMPTY = "NewFolderDialog.folderNameEmpty"; //$NON-NLS-1$
 	private static final String ERROR_FOLDER_NAME_INVALID = PREFIX + ".error.Folder_name_invalid"; //$NON-NLS-1$
 	
 	/* (non-Javadoc)
@@ -152,7 +149,7 @@
 		// Instantiate the macros button
 		advancedButton = new Button(parent, SWT.PUSH);
 		applyDialogFont(advancedButton);
-		advancedButton.setText(IDEWorkbenchMessages.getString(SHOW));
+		advancedButton.setText(IDEWorkbenchMessages.showAdvanced);
 		setButtonLayoutData(advancedButton);
 		GridData data = (GridData) advancedButton.getLayoutData();
 		data.horizontalAlignment = GridData.BEGINNING;
@@ -275,16 +272,16 @@
 			macroComposite = ControlFactory.createComposite(composite, 1);
 			shellSize = shell.computeSize(SWT.DEFAULT, SWT.DEFAULT, true);
 			shell.setSize(shellSize);
-			advancedButton.setText(IDEWorkbenchMessages.getString(HIDE)); 
+			advancedButton.setText(IDEWorkbenchMessages.hideAdvanced); 
 		} else if (macroComposite.getVisible()) {
 			macroComposite.setVisible(false);
 			shell.setSize(shellSize.x, basicShellHeight);
-			advancedButton.setText(IDEWorkbenchMessages.getString(SHOW));
+			advancedButton.setText(IDEWorkbenchMessages.showAdvanced);
 		} else {
 			macroComposite.setVisible(true);
 			shellSize = shell.computeSize(SWT.DEFAULT, SWT.DEFAULT, true);
 			shell.setSize(shellSize);
-			advancedButton.setText(IDEWorkbenchMessages.getString(HIDE));
+			advancedButton.setText(IDEWorkbenchMessages.hideAdvanced);
 		}
 		
 	}
@@ -322,7 +319,7 @@
 		folderName = text.getText();
 		// Empty or null string is invalid
 		if (folderName == null || folderName.equals("")) { //$NON-NLS-1$
-			updateStatus(IStatus.ERROR, IDEWorkbenchMessages.getString(EMPTY));
+			updateStatus(IStatus.ERROR, IDEWorkbenchMessages.ResourceGroup_folderEmpty);
 			return;
 		} else {
 			// Make sure that the specified location exists

Back to the top