| [cdt-dev] NPE in Managed Build, was RE: Committed: [cdt-patch] Managed Build System - Enumerated option reference - Fix for PR 61596 |
|
Sean,
I’m emailing this rather than filing a bug with a patch because I’m not sure if this is already known and being worked on…
Has the fix for the situation Leo describes been fully addressed yet?
After the first time I modify my project configuration, if I go again to modify it, clicking the OK button gives me an NPE. The NPE doesn’t bring the system down but OK does not work and the only way out of the dialog is via the Cancel button. So basically, after the first time you modify your settings, you can never modify them again :-(
The NPE happens because when getEnumeratedId() is called on the option reference, it compares the ID to the name from the enum name map and they’re not equal, so it returns null.
/* (non-Javadoc) * @see org.eclipse.cdt.managedbuilder.core.IOption#getEnumeratedId(java.lang.String) */ public String getEnumeratedId(String name) { if (name == null) return null; Set idSet = getEnumNameMap().keySet(); Iterator iter = idSet.iterator(); while (iter.hasNext()) { String id = (String) iter.next(); String enumName = (String) getEnumNameMap().get(id); if (name.equals(enumName)) { return id; } } return null; }
There are no null checks in BuildToolSettingsPage.performOk(), so the line highlighted in green below goes BLAMMO…
// Transfer value from preference store to options switch (option.getValueType()) { case IOption.BOOLEAN : boolean boolVal = getPreferenceStore().getBoolean(option.getId()); ManagedBuildManager.setOption(configuration, option, boolVal); break; case IOption.ENUMERATED : String enumVal = getPreferenceStore().getString(option.getId()); String enumId = option.getEnumeratedId(enumVal); ManagedBuildManager.setOption(configuration, option, (enumId.length() > 0) ? enumId : enumVal); break;
Basically, these calls originating from BuildToolSettingsPage.performOk() are redundant now… you already have the ID, so you don’t need to resolve it in any way. Just call setOption and you’re done.
Stack trace for the NPE is below:
org.eclipse.core.launcher.Main at localhost:2122 Thread [main] (Suspended (exception NullPointerException)) BuildToolSettingsPage.performOk() line: 436 BuildPropertyPage.performOk() line: 888 PropertyDialog(PreferenceDialog).okPressed() line: 741 PropertyDialog(PreferenceDialog).buttonPressed(int) line: 198 Dialog$2.widgetSelected(SelectionEvent) line: 505 TypedListener.handleEvent(Event) line: 89 EventTable.sendEvent(Event) line: 82 Button(Widget).sendEvent(Event) line: 796 Display.runDeferredEvents() line: 2725 Display.readAndDispatch() line: 2390 PropertyDialog(Window).runEventLoop(Shell) line: 668 PropertyDialog(Window).open() line: 648 PropertyDialogAction.run() line: 177 ProjectPropertyDialogAction.run() line: 69 ProjectPropertyDialogAction(Action).runWithEvent(Event) line: 881 ActionContributionItem.handleWidgetSelection(Event, boolean) line: 899 ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 850 ActionContributionItem$7.handleEvent(Event) line: 769 EventTable.sendEvent(Event) line: 82 MenuItem(Widget).sendEvent(Event) line: 796 Display.runDeferredEvents() line: 2725 Display.readAndDispatch() line: 2390 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 1353 Workbench.runUI() line: 1324 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 243 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 141 IDEApplication.run(Object) line: 90 PlatformActivator$1.run(Object) line: 298 EclipseStarter.run(Object) line: 249 EclipseStarter.run(String[], Runnable) line: 126 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 39 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25 Method.invoke(Object, Object[]) line: 324 Main.basicRun(String[]) line: 269 Main.run(String[]) line: 722 Main.main(String[]) line: 706 Thread [Framework Event Dispatcher] (Running) Thread [Start Level Event Dispatcher] (Running) Thread [Thread-0] (Running) Thread [Thread-1] (Running) Thread [CDT Indexer] (Running) Thread [Indexer TimeOut Thread] (Running) Thread [Worker-0] (Running) Thread [Time Out Thread] (Running) Thread [org.eclipse.cdt.internal.ui.text.CSourceViewerConfiguration$1] (Running)
___________________________________________
Chris Recoskie Software Designer IDE Frameworks Group Texas Instruments, Toronto
-----Original Message-----
|