[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[cdt-debug-dev] BreakpointManager.java is broken
|
The attached patch disables broken code in BreakpointManager.java
I don't know what the fix is, but the file name can be
the binary e.g. foo.elf, so the syntax break foo.c:xxx can't be
blindly used.
I think it is best to disable this code until it can be implemented
correctly.
Objections?
--
Øyvind Harboe
http://www.zylin.com - eCos ARM & FPGA developer kit
### Eclipse Workspace Patch 1.0
#P org.eclipse.cdt.debug.mi.core
Index: cdi/org/eclipse/cdt/debug/mi/core/cdi/BreakpointManager.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/BreakpointManager.java,v
retrieving revision 1.47
diff -u -r1.47 BreakpointManager.java
--- cdi/org/eclipse/cdt/debug/mi/core/cdi/BreakpointManager.java 28 Mar 2008 15:42:17 -0000 1.47
+++ cdi/org/eclipse/cdt/debug/mi/core/cdi/BreakpointManager.java 2 Apr 2008 13:46:26 -0000
@@ -959,9 +959,12 @@
if (colon != -1) {
line.append(function);
} else {
- if (file != null && file.length() > 0) {
- line.append(file).append(':');
- }
+ // FIX!!! sometimes the file can be the name of the binary(foo.elf)
+ // in which case this does not work.
+ // if (file != null && file.length() > 0) {
+ // line.append(file).append(':');
+ // }
+
// GDB does not seem to accept function arguments when
// we use file name:
// (gdb) break file.c:Test(int)
