Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-debug-dev] Putting bug number 86676 to rest

This patch puts bug 86676 to pasture.

There are good reasons why this must be fixed in GDB and the
patch assures an acceptable behaviour by Eclipse meanwhile(no
modal dialog boxes).

"Patch & commit" ping test #2

-- 
Øyvind Harboe
http://www.zylin.com - eCos ARM & FPGA developer kit
### Eclipse Workspace Patch 1.0
#P org.eclipse.cdt.debug.mi.core
Index: cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Thread.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.cdt/all/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Thread.java,v
retrieving revision 1.21
diff -u -r1.21 Thread.java
--- cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Thread.java	13 Mar 2008 08:59:36 -0000	1.21
+++ cdi/org/eclipse/cdt/debug/mi/core/cdi/model/Thread.java	31 Mar 2008 11:58:34 -0000
@@ -185,9 +185,15 @@
 						}
 					}
 				} catch (MIException e) {
-					throw new MI2CDIException(e);
-				} finally {
-					target.setCurrentThread(currentThread, false);
+					/* GDB has a bug where it fails to evaluate the stack depth, this must, ultimately
+					 * be fixed in GDB. GNAT nr 2395
+					 * 
+					 * http://sourceware.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=2395&return_url=http%3A%2F%2Fsourceware.org%2Fcgi-bin%2Fgnatsweb.pl%3Fdatabase%3Dgdb%26category%3Dthreads%26severity%3Dall%26priority%3Dall%26responsible%3Dall%26submitter_id%3Dall%26state%3Dall%26ignoreclosed%3DIgnore%2520Closed%26class%3Dall%26synopsis%3D%26multitext%3D%26columns%3Dcategory%26columns%3Dstate%26columns%3Dclass%26columns%3Dresponsible%26columns%3Dsynopsis%26displaydate%3DDisplay%2520Current%2520Date%26cmd%3Dsubmit%2520query%26sortby%3DResponsible%26.cgifields%3Ddisplaydate%26.cgifields%3Dignoreclosed%26.cgifields%3Doriginatedbyme%26.cgifields%3Dcolumns
+					 */
+					// Bug#86676 fix:
+					// 
+					// 1 is safe
+					return 1;
 				}
 			}
 		}

Back to the top