[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [bpel-dev] Trouble with ReconciliationHelper
|
Hi Hanyu,
Also I've a similar problem with the ServiceRef, I've fixed it too.
I've asked Oleg to commit these fixes.
Thanks,
Dennis
2008/5/4 Dennis Ushakov <dennis.ushakov@xxxxxxxxx>:
> Hi Hanyu,
>
> I've fixed the problem in Wait, ForEach, OnAlarm, Targets, Source. I
> see no other usages of createExpressionElement() not guarded by
> isLoading(), please report if you encounter similar problems
>
> Thanks,
> Dennis
>
> 2008/5/2 Hanyu Xiao <hxiao@xxxxxxxxx>:
>
>
> > Hi Dennis,
> >
> > Thank you for the fix to ReconciliationHelper. I've found similar problems in a few more classes in the package "org.eclipse.bpel.model.impl". Basically every time "ElementFactory.getInstance().createExpressionElement()" is called, it is assumed that the DOM element was already present. As a result, we are getting NPEs with our in-memory BPEL models. Could you have these classes fixed, too?
> >
> > Best wishes,
> > Hanyu
> >
> >
> >
> > -----Original Message-----
> > From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx] On Behalf Of Dennis Ushakov
> > Sent: Monday, March 24, 2008 10:18 AM
> > To: BPEL Designer project developer discussions.
> >
> >
> > Subject: Re: [bpel-dev] Trouble with ReconciliationHelper
> >
> > Hi Simon,
> >
> > I agree with you. I've asked Oleg to commit it
> >
> > Thanks,
> > Dennis
> >
> > 2008/3/24, Simon D Moser <SMOSER@xxxxxxxxxx>:
> > > Hey Dennis,
> > >
> > > I think there is a valid use case of code generation that Hanyu describes
> > > here. Therefore, I support the idea that we skip synchronization if no DOM
> > > elements are present (it really makes no sense to foce people to generate
> > > DOM elements when they do codegen). Once it is written out to a file and
> > > read back in, the DOM is there and there is no issue anymore. So yes, pls.
> > > go ahead with this!
> > >
> > > Cheers
> > > Simon
> > >
> > > Simon Moser, M.Eng.
> > >
> > >
> > >
> > > Websphere Integration Mail: IBM Deutschland (Embedded
> > > Developer Development smoser@de.i Entwicklung GmbH image
> > > Team Lead BPEL Editor bm.com Vorsitzender des moved to
> > > Dept. 4722, Bldg. Phone: Aufsichtsrats: Martin file:
> > > 71032-01, Room 086 +49-7031-16 Jetter pic11622.g
> > > Websphere Solutions -4304 Geschäftsführung: if)I'm
> > > and Services Fax: Herbert Kircher speaking
> > > IBM Deutschland +49-7031-16 Sitz der Gesellschaft: at
> > > Entwicklung GmbH -4890 Böblingen EclipseCon
> > > Schönaicherstr. 220, Registergericht: 2008
> > > D - 71032 Boeblingen Amtsgericht Stuttgart,
> > > HRB 243294
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > |------------>
> > > | From: |
> > > |------------>
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > >
> > > |"Dennis Ushakov" <dennis.ushakov@xxxxxxxxx> |
> > >
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |------------>
> > > | To: |
> > > |------------>
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |"BPEL Designer project developer discussions." <bpel-dev@xxxxxxxxxxx>, "Hanyu Xiao" <hxiao@xxxxxxxxx> |
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |------------>
> > > | Date: |
> > > |------------>
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |24.03.2008 15:51 |
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |------------>
> > > | Subject: |
> > > |------------>
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > > |Re: [bpel-dev] Trouble with ReconciliationHelper |
> > > >--------------------------------------------------------------------------------------------------------------------------------------------------|
> > >
> > >
> > >
> > >
> > >
> > >
> > > Hi Hanyu,
> > >
> > > These problems are happening because there's no DOM elements when
> > > you're creating EMF elements like this. I have fix that makes
> > > ReconciliationHelper simply skip synchronization in case there's no
> > > DOM. But if you intend on using DOM later in your code I need to come
> > > with some solution that allows to create DOM element at the moment
> > > when EMF one is created.
> > > For me it seems completely ok to have simply skip synchronization to
> > > DOM when we have none, but if anyone has any objections - please speak
> > > out.
> > >
> > > Thanks,
> > > Dennis
> > >
> > > 2008/3/23, Dennis Ushakov <dennis.ushakov@xxxxxxxxx>:
> > > > Hi Hanyu,
> > > >
> > > > It seems that it's the problem with my code so I'll take a look at it.
> > > > I hope I'll submit patch somewhere at the beginning of the next week
> > > >
> > > > Thanks,
> > > >
> > > > Dennis
> > > >
> > >
> > > _______________________________________________
> > > bpel-dev mailing list
> > > bpel-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > >
> > > _______________________________________________
> > > bpel-dev mailing list
> > > bpel-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > >
> > >
> > >
> > _______________________________________________
> > bpel-dev mailing list
> > bpel-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > _______________________________________________
> > bpel-dev mailing list
> > bpel-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> >
>
