Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [bpel-dev] Undo for namespaces change

Hi Dennis,
                                                                
 this is how to reproduce the bug of missing actions after      
 opening a .bpel file that I discovered:                        
                                                                
 1. Create a new BPEL process                                   
 2. Put an Empty (or any other basic activity) into the main    
 sequence (it contains now three activities)                    
 3. Save & Close the BPEL file                                  
 4. Open it again -> basic activity is not displayed, only      
 receive and reply                                              
 5. Add another new basic activity into the main sequence ->    
 both basic activity are displayed                              
                                                                
 Similiar problem with controls like an if:                     
                                                                
 1. Create a new BPEL process                                   
 2. Put an if into the main sequence                            
 3. Add an else to the if control                               
 4. Save & Close the BPEL file                                  
 5. Open it again -> activity is not displayed                  
 6. Put any action into the main sequence -> if control is      
 there, BUT the 'else' is still missing!                        
                                                                
 In both cases the XML source is ok, i.e. the elements are in   
 it, just on the first opening the elements are not displayed.  
 Any ideas what might cause this ?                              
                                                                



As for the command stack - this is a tricky one. I want  a night to sleep
over it - let me get back on this.

Cheers
Simon

Simon Moser, M.Eng.


                                                                         
 Websphere Integration  Mail:        IBM Deutschland          (Embedded  
 Developer Development  smoser@de.i  Entwicklung GmbH         image      
 Team Lead BPEL Editor  bm.com       Vorsitzender des         moved to   
 Dept. 4722, Bldg.      Phone:       Aufsichtsrats: Martin    file:      
 71032-01, Room 086     +49-7031-16  Jetter                   pic18272.g 
 Websphere Solutions    -4304        Geschäftsführung:        if)I'm     
 and Services           Fax:         Herbert Kircher          speaking   
 IBM Deutschland        +49-7031-16  Sitz der Gesellschaft:   at         
 Entwicklung GmbH       -4890        Böblingen                EclipseCon 
 Schönaicherstr. 220,                Registergericht:         2008       
 D – 71032 Boeblingen                Amtsgericht Stuttgart,              
                                     HRB 243294                          
                                                                         









                                                                                                                       
  From:       "Dennis Ushakov" <dennis.ushakov@xxxxxxxxx>                                                              
                                                                                                                       
  To:         "BPEL Designer project developer discussions." <bpel-dev@xxxxxxxxxxx>                                    
                                                                                                                       
  Date:       14.02.2008 14:00                                                                                         
                                                                                                                       
  Subject:    Re: [bpel-dev] Undo for namespaces change                                                                
                                                                                                                       





Hi Simon,

I think that we should be able to undo changes done in source tab in
design view and vice versa. This is why we may want to have effects in
graphical view.
I've looked at this problem a little deeper and it seem that we have
big inconsistency in how whole undo mechanism behaves. We're having
two completely independent stacks for design and source views. And
wrapping reconciliation into UpdateModelCommand results in following:
we change something in source tab, switch to design, undo text change,
and source tab has 2 undo's instead of 0.
To fix this problem I see two ways. To have one command stack for both
tabs. Or to have some kind of placeholder command that says that undo
should be done in other stack.

I'll take a look at your scenario with disappearing activities and try
to find out where the problem is if I manage to reproduce it.

Thanks,
Dennis

2008/2/13, Simon D Moser <SMOSER@xxxxxxxxxx>:
> Hi Dennis,
>
>  mmh, the problem here is that EMF EObject, unlike DOM nodes, do not
carry
>  around the namespaces. Therefore, this can be changed on a DOM level,
but
>  since that change wouldnt be visible in the rgaphical BPEL, EMF doesn't
>  care. Only the BPEL writer cares. This is a tricky question actually.
>
>  Why would we want that (== change of a namespace prefix) to have effects
in
>  the graphical  view anyway ? Is there any reason for that (I am asking
that
>  stupid because I don't see any reason) ?
>
>  Cheers
>  Simon
>
>  ps..: By the way, I found yesterday that when you create a process that
has
>  a structued activity (lets say a sequence, and then a while in that
>  sequence, and then a something else in the while), and you save and
close
>  everything is fine. But once you reopen the process, then the inner
>  activities are lost (at least in the graphical view). To me this might
be
>  caused by the DOM Facading work - did anyone of you ever notice that ?
Or
>  is this just happening on my machine ?
>
>  Simon Moser, M.Eng.
>
>
>
>   Websphere Integration  Mail:        IBM Deutschland          (Embedded
>   Developer Development  smoser@de.i  Entwicklung GmbH         image
>   Team Lead BPEL Editor  bm.com       Vorsitzender des         moved to
>   Dept. 4722, Bldg.      Phone:       Aufsichtsrats: Martin    file:
>   71032-01, Room 086     +49-7031-16  Jetter                   pic30430.g
>   Websphere Solutions    -4304        Geschäftsführung:        if)I'm
>   and Services           Fax:         Herbert Kircher          speaking
>   IBM Deutschland        +49-7031-16  Sitz der Gesellschaft:   at
>   Entwicklung GmbH       -4890        Böblingen                EclipseCon
>   Schönaicherstr. 220,                Registergericht:         2008
>   D – 71032 Boeblingen                Amtsgericht Stuttgart,
>                                      HRB 243294
>
>
>
>
>
>
>
>
>
>
>
>   From:       "Dennis Ushakov" <dennis.ushakov@xxxxxxxxx>
>
>   To:         "BPEL Designer project developer discussions."
<bpel-dev@xxxxxxxxxxx>
>
>   Date:       13.02.2008 16:10
>
>   Subject:    [bpel-dev] Undo for namespaces change
>
>
>
>
>
>
>
>  Hi!
>
>  I'm currently working on making namespaces support in BPEL Editor
>  correct. Currently version in repository is working correctly only
>  with "bpws" prefix for BPEL elements. I've fixed this problem and some
>  others regarding creation of elements with correct namespace prefix.
>  But I've got one issue left.
>  If I edit namespace prefix or url in source tab I can easily undo my
>  changes in the source tab. But to be able to undo these changes from
>  design view I need to add undo command to design view command stack.
>  It seems to me that UpdateModel cannot be used because EMF-object
>  doesn't notify about namespace change. It simply has no such feature.
>  Could you give me a clue how should such a command be implemented? Or
>  is it better to introduce some feature to notify recorder about
>  namespace changes?
>
>  Thanks,
>  Dennis
>
> _______________________________________________
>  bpel-dev mailing list
>  bpel-dev@xxxxxxxxxxx
>  https://dev.eclipse.org/mailman/listinfo/bpel-dev
>
> _______________________________________________
>  bpel-dev mailing list
>  bpel-dev@xxxxxxxxxxx
>  https://dev.eclipse.org/mailman/listinfo/bpel-dev
>
>
>
_______________________________________________
bpel-dev mailing list
bpel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/bpel-dev

Attachment: pic18272.gif
Description: GIF image


Back to the top