Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [bpel-dev] patch11=elements-added-with-name-attributes-in-sequence

Reviewed and checked in !

Simon Moser, M.Eng.


                                                                          
 Websphere Integration       Mail:           IBM Deutschland Entwicklung  
 Developer Development       smoser@xxxxxx.  GmbH                         
 Team Lead BPEL Editor       com             Vorsitzender des             
 Dept. 4722, Bldg.           Phone:          Aufsichtsrats: Martin Jetter 
 71032-01, Room 086          +49-7031-16-43  Geschäftsführung: Herbert    
 Websphere Solutions and     04              Kircher                      
 Services                    Fax:            Sitz der Gesellschaft:       
 IBM Deutschland             +49-7031-16-48  Böblingen                    
 Entwicklung GmbH            90              Registergericht: Amtsgericht 
 Schönaicherstr. 220, D –                    Stuttgart, HRB 243294        
 71032 Boeblingen                                                         
                                                                          








                                                                           
             "Tishkov, Vitaly                                              
             V"                                                            
             <vitaly.v.tishkov                                          To 
             @intel.com>               "BPEL Designer project developer    
             Sent by:                  discussions."                       
             bpel-dev-bounces@         <bpel-dev@xxxxxxxxxxx>              
             eclipse.org                                                cc 
                                                                           
                                                                   Subject 
             08/07/2007 12:24          [bpel-dev]                          
             PM                        patch11=elements-added-with-name-at 
                                       tributes-in-sequence                
                                                                           
             Please respond to                                             
              "BPEL Designer                                               
             project developer                                             
               discussions."                                               
             <bpel-dev@eclipse                                             
                   .org>                                                   
                                                                           
                                                                           




Hi Simon,

This little patch #11 fixed the first two points from the TODO list (
https://bugs.eclipse.org/bugs/show_bug.cgi?id=197468):

1. Elements are added into the DOM model (and thus in the source tab)
without the name attribute.
2. Renaming just added elements in the design tab doesn’t affect the
corresponding nodes in the source tab until the file is saved.

Things may work badly inside structured activities other than Sequence.
This will work once I complete for other structured activities  what I did
in patch #9 (changes made in Sequence sub-nodes in the source tab are
reflected in the design tab).

Thanks,
            Vitaly.(See attached file:
patch11=elements-added-with-name-attributes-in-sequence.txt)
_______________________________________________
bpel-dev mailing list
bpel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/bpel-dev
### Eclipse Workspace Patch 1.0
#P org.eclipse.bpel.ui
Index: src/org/eclipse/bpel/ui/commands/InsertInContainerCommand.java
===================================================================
RCS file: /cvsroot/technology/org.eclipse.bpel/plugins/org.eclipse.bpel.ui/src/org/eclipse/bpel/ui/commands/InsertInContainerCommand.java,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 InsertInContainerCommand.java
--- src/org/eclipse/bpel/ui/commands/InsertInContainerCommand.java	22 Jul 2007 16:34:38 -0000	1.1.2.1
+++ src/org/eclipse/bpel/ui/commands/InsertInContainerCommand.java	7 Aug 2007 10:21:50 -0000
@@ -10,6 +10,8 @@
  *******************************************************************************/
 package org.eclipse.bpel.ui.commands;
 
+import org.eclipse.bpel.model.Activity;
+import org.eclipse.bpel.model.resource.BPELResource;
 import org.eclipse.bpel.ui.Messages;
 import org.eclipse.bpel.ui.adapters.IContainer;
 import org.eclipse.bpel.ui.adapters.ILabeledElement;
@@ -68,10 +70,11 @@
 	    	beforeElement = org.eclipse.bpel.ui.util.BPELEditorUtil.getInstance().getElementForObject(before);
 	    }
 	    
-	    MyBPELWriter writer = new MyBPELWriter((org.eclipse.bpel.model.resource.BPELResource)(parent.eResource()),
+	    MyBPELWriter writer = new MyBPELWriter((BPELResource)(parent.eResource()),
 	    										parentElement.getOwnerDocument());
 
-	    Element childElement = writer.activity2XML(((org.eclipse.bpel.model.Activity)child));
+	    Element childElement = writer.activity2XML(((Activity)child));
+	    ((Activity)child).setElement(childElement);
 
 	    parentElement.insertBefore(childElement, beforeElement);
 	}

Back to the top