RE: [bpel-dev] DOM Facading / source Editor

["Tishkov, Vitaly V" <vitaly.v.tishkov@xxxxxxxxx>]

Simon, all,

>Therefore, it is important to find out what Vitaly is planning for the
>sourceView ? Is it something like the SSE Editors (Structured Source
>Editors) that are available for e.g. XML ?

Yes, this is true. 
There are two reasons for that:
	1) BPEL editor will be consistent with other XML and XML-like Eclipse editors (WSDL, XSD);
	2) code from XML/XSD/WSDL editors can be reused.


There is a problem though. 
WSDL/XSD/XML editor use org.eclipse.ui.MultipageEditorPart which is designed for creating multi-page editors. 

As far as I understand WSDL/XSD/XML editor cores are build on top of this class, i.e. they build a model from a document, create additional views like outline view, handle property changes, etc. Graphic and source parts of the editors are just views which display the model various ways. 

In our case BPELEditor is that core part but it also displays a document model. 
My initial idea was to create a subclass of org.eclipse.ui.MultipageEditorPart, move there all the editor core functions from BPELEditor and make BPELEditor just a view. This will allow adding source tab view (or any other views, e.g. XML view) easily. But BPEL editor traces are everywhere and it's a big challenge to do move core editor code from BPELEditor to anywhere else. I spent a few days on that and gave up eventually. 

So, I decided to do the following: utilize a subclass of org.eclipse.ui.MultipageEditorPart, add BPELEditor and org.eclipse.wst.sse.ui.StructuredTextEditor as views but keep core editor functionality in BPELEditor. This seems to be a bit lame from the design point of view but if anyone can propose anything else or volunteer to move core editor functionality from BPELEditor to a subclass of org.eclipse.ui.MultipageEditorPart, it would be great. I can clean up code I have at the moment and send it to the volunteer.

>I think we need to have a phone call on this soon, since we have to decide
>how to proceed from here. I understood the concepts that I have to watch,
>but this change requires a bigger amount of restructuring and even more
>testing, so were looking at something like 10-15 days full time work (which
>really is hard to contain until end of May).

I'll need to stay quite late in the evening (I'm located in St. Petersburg, Russia, GMT+3). I can do it this Friday (May, 18), next Monday (21) and next Wednesday (23).

Thanks,
	Vitaly.







>-----Original Message-----
>From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx] On
>Behalf Of Simon D Moser
>Sent: Thursday, May 17, 2007 12:11 AM
>To: BPEL Designer project developer discussions.
>Subject: [bpel-dev] DOM Facading / source Editor
>
>
>Hey guys,
>
>We started to dig deeper in the DOM Facading work this week, and it turns
>out that this more complicated than I initially expected. So today I then
>had a call with the WTP / WSDL guys in order to find out how they do it,
>and I learned quite a lot. That is the good news. The bad news, however, is
>that given we really like to go for a sourceView, that makes things even
>more comlicated (you have to synchronise both ways, DOM->EMF and EMF-DOM
>since most sourceEditors work on a DOM, not on an EMF.)
>Therefore, it is important to find out what Vitaly is planning for the
>sourceView ? Is it something like the SSE Editors (Structured Source
>Editors) that are available for e.g. XML ?
>
>I think we need to have a phone call on this soon, since we hace to decide
>how to proceed from here. I understood the concepts that I have to watch,
>but this change requires a bigger amount of restructuring and even more
>testing, so were looking at something like 10-15 days full time work (which
>really is hard to contain until end of May).
>Either way, let me know your availabilty, I won't be available next Friday
>(May 25) where our next regular conf call is scheduled, so lets see how we
>can reschedule this.
>
>Thanks
>Simon
>
>Simon Moser, M.Eng.
>
>
>
> Websphere Integration       Mail:           IBM Deutschland Entwicklung
> Developer Development       smoser@xxxxxx.  GmbH
> Team Lead BPEL Editor       com             Vorsitzender des
> Dept. 4722, Bldg.           Phone:          Aufsichtsrats: Martin Jetter
> 71032-01, Room 086          +49-7031-16-43  Geschäftsführung: Herbert
> Websphere Solutions and     04              Kircher
> Services                    Fax:            Sitz der Gesellschaft:
> IBM Deutschland             +49-7031-16-48  Böblingen
> Entwicklung GmbH            90              Registergericht: Amtsgericht
> Schönaicherstr. 220, D -                    Stuttgart, HRB 243294
> 71032 Boeblingen
>
>
>
>