Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev] CHECKIN: AbstractDialogBase.js Ok button and size

Description:

Fixed two issues with AbstractDialogBase.js

 

1. - Ok button:

Fixed bug in function _setOKButtonState. Multiple listeners were added if enabled button was enabled. Now the enabled state of button is checked and listener is only added if state has changed.

 

2. - Dialog size and iframe location:

Dialog size is calculated so that it includes an inner and outer border if present. The iframe is moved so that it lines up with the real dialog border (assumes dialog border left/right, top/bottom are same width)

Regression: Yes/No
No

Code Owner:
Viewer team

Code Reviewers:
Jun Zhai

Tests:
Viewed locally

Test Automated:  Yes/No (if “No”, then explain why)
No – needs user interaction.

Branches Involved:
Eclipse CVS

Files Changed:
/org.eclipse.birt.report.viewer/birt/webcontent/birt/ajax/ui/dialog/AbstractBaseDialog.js

Files Shared:
None

Files Added:
None

Files Deleted:
None

Defect Entries Resolved:
None

Case Entries Resolved:
None

Notes to Developers:
None

Notes to QA:
None

Notes to Documentation:
None

Notes to Configuration Management:
None

 

 

Catherine Block

Actuate Corporation

Tel: 650-837-4834

 


Back to the top