[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [aspectj-users] automatic comments at selected joinpoints

Hi Marcel,
AspectJ does not touch the java source code, it acts on .class files directly. In fact, it does not need source files of the classes it is weaving at all, so it cannot add comments to it. Moreover, it could easily become a mess adding and removing comments, causing svn commits on files which haven't been modified and so on.


What you can do is save in a file the output of the weaving, which tells you which advices are applied to which join points in code, or save the ajsym file that contains a java serialized version of such informations. Both are generated by ajc using build parameters.

I do admit that, if not using eclipse, it's not easy to understand that a certain point in code is being adviced by some aspects. But it should be that way : the aspect should be "transparent", be "one aspect", and let the programmer free to code without having to worry about which aspects are doing what somewhere in the code.

Hope this helps clarify,
Simone

Marcel Schiffel wrote:
No, I think there should (optionally) just be a small notice at certain places in the java source files, indicating that a pointcut might apply to these points. Without any comment (or a visual aid from the IDE) the reader of plain java files might forget that additional code might be woven it at that places and misinterprets the source code.



2009/1/16 Andrew Eisenberg <andrew@xxxxxxxxxxxx <mailto:andrew@xxxxxxxxxxxx>>

    Are you suggesting that AJDoc comments should be added in the same way
    that JavaDoc comments are automatically added for new methods?

    Please open an enhancement request on Bugzilla for this:
    https://bugs.eclipse.org/bugs/enter_bug.cgi

    On Thu, Jan 15, 2009 at 11:52 PM, Marcel Schiffel
    <marcelschiffel@xxxxxxxxxxxxxx
    <mailto:marcelschiffel@xxxxxxxxxxxxxx>> wrote:
    > Hi,
    >
    > is it possible to automatically add comments at places where
    pointcuts
    > apply? This would improve readability of the code (java files)
    outside
    > eclipse. If not, this might be a cool feature for future releases.
    >
    > Many thanks in advance!
    >
    >
    > _______________________________________________
    > aspectj-users mailing list
    > aspectj-users@xxxxxxxxxxx <mailto:aspectj-users@xxxxxxxxxxx>
    > https://dev.eclipse.org/mailman/listinfo/aspectj-users
    >
    >
    _______________________________________________
    aspectj-users mailing list
    aspectj-users@xxxxxxxxxxx <mailto:aspectj-users@xxxxxxxxxxx>
    https://dev.eclipse.org/mailman/listinfo/aspectj-users


------------------------------------------------------------------------

_______________________________________________
aspectj-users mailing list
aspectj-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-users


--
Simone Gianni            CEO Semeru s.r.l.           Apache Committer
http://www.simonegianni.it/