Re: [aspectj-dev] getting more detailed information from the weaver

[Andy Clement <andrew.clement@xxxxxxxxx>]

Hi Martin,

> As far as I know these could be the woven aspects themselves but also
> additional types (for caught exceptions via around advices, for example).

I would also include the types in the aspectj runtime jar.  And I imagine an
ITD could also introduce an unexpected dependency on just about
anything:

public SomeTypeFromOtherThere SomeType.field;

I'm in two minds about whether the easiest thing to do is to diff the before
and after versions of the class and pull out the new class references in
the constant pool, or to collect the dependencies as the weaver does its job.

Either way, we need a new enhancement request opening (want to do that?)

There is a model that drives the UI which captures what files are affected
by what and the relevant information is in there, but the model would be a very
expensive thing to create/maintain whilst load time weaving.  I'd probably
try and compute the dependencies as we go in the weaver (and provide a way
to collect them at the end), but if it proves just too
messy/difficult, then go with
a diffing implementation.

cheers,
Andy

On 12 October 2010 04:10, Martin Lippert <lippert@xxxxxxx> wrote:
> Hi!
>
> Within the Equinox space we are currently investigating a reimplementation
> of Equinox Weaving based on the new OSGi weaving hook spec. During this
> discussion we came across the additional dependencies between bundles that
> the weaving might produce. Currently Equinox Weaving uses a self-implemented
> supplementer mechanism to realize this, but this doesn't conform well to the
> OSGi bundle wiring mechanisms.
>
> We thought about a better solution for this and it would be perfect if the
> weaver could tell us (after a class got woven) which type references (or
> packages of those) were added to the class because of the weaving (then we
> could add exactly those import statements and let OSGi wire them for us). As
> far as I know these could be the woven aspects themselves but also
> additional types (for caught exceptions via around advices, for example).
>
> Any idea how to get this information from the weaver?
>
> Thanks for your help!!!
>
> Cheers,
> -Martin
>
> _______________________________________________
> aspectj-dev mailing list
> aspectj-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/aspectj-dev
>