Re: [aspectj-dev] 1.1rc2 building

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [aspectj-dev] 1.1rc2 building
From: Wes Isberg <wes@xxxxxxxxxxxxxx>
Date: Tue, 29 Apr 2003 12:28:04 -0700
Delivered-to: aspectj-dev@xxxxxxxxxxx
List-archive: <http://dev.eclipse.org/pipermail/aspectj-dev/>
List-help: <mailto:aspectj-dev-request@eclipse.org?subject=help>
List-subscribe: <http://dev.eclipse.org/mailman/listinfo/aspectj-dev>, <mailto:aspectj-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <http://dev.eclipse.org/mailman/listinfo/aspectj-dev>, <mailto:aspectj-dev-request@eclipse.org?subject=unsubscribe>
Thanks for doing this, George!

As for the snags, I assume you followed the instructions in

  build/readme-build-and-test-aspectj.html

esp. "Running the Ant build scripts from Eclipse"?  There it mentions
removing ALL eclipse libraries and only running with ours. Did that
not work for you?  

I can imagine that upgrading AspectJ to eclipse 2.1 bound it to newer
versions of the Xerces parser.  Your fix might be correct, if we
accept Ant prepending its classpath to the specified user classpath, 
but I'll look into disabling that in the builder
(includeAntClasspath=false).  I'd like to avoid changing our build
libraries every time there's a binary-incompatible overlap.

In any case, I believe a release build should only be done from the 
command-line using (Sun 1.3 and) the jars checked into CVS in the lib
directory.  This should do it:

  set JAVA_HOME={pathToJDK}
  cd modules/build
  ../lib/ant/bin/ant  (clean beforehand if needed)

Somehow to me that's a more controlled scenario, though running 
Ant in eclipse *should* work just fine.

(fyi, I'm trying to get ajbrowser to a usable state, with incremental
builds, before rc2.)

Regards,
Wes

P.S. Just for others' convenience, here are the test failures.
The NPE in structure builder should be investigated.

-------------- In 1.3.1:
------------  FAIL: elaborated into testing of around on all join points()
--- result: false
[  0] ------------  PASS: CompilerRun(CompilerRun.Spec AjdtCommand(1 paths))
[  0] --- result: true
[  0] --- messages 
[  0] MessageHolder:  (5 info) 
[  0] [info   0]: info org.aspectj.ajdt.ajc.AjdtCommand@30af424b([-d, C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes, -classpath, C:\DOCUME~1\gharley\LOCALS~1\Temp\SandboxKD85EM\classes;..\lib\test\aspectjrt.jar;..\lib\test\testing-client.jar, C:\eclipse-21-Release\eclipse\workspace\tests\new\AroundAll.java]) 
[  0] [info   1]: info directory classpath entry does not exist: C:\ibm-sdk-131-sr3\jre\classes 
[  0] [info   2]: info compiling C:\eclipse-21-Release\eclipse\workspace\tests\new\AroundAll.java 
[  0] [info   3]: info weaving 
[  0] [info   4]: info might need to weave [UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\AroundAll.class, AroundAll), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\A.class, A), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\SuperC.class, SuperC), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\C.class, C)](world=true) 
[  1] ------------  FAIL: JavaRun(JavaRun(AroundAll))
[  1] --- result: true
[  1] --- messages 
[  1] MessageHolder:  (1 info)  (2 fail) 
[  1] [info   0]: info childResult != result=true 
[  1] [fail   0]: fail steps: enter execution(void AroundAll.main(String[])) != enter execution(void AroundAll.main(ClassNotFoundException)) at index 2 
[  1] [fail   1]: fail [ expected steps "enter execution(void AroundAll.main(String[]))" not found,  unexpected steps "enter execution(void AroundAll.main(ClassNotFoundException))" found] 

-------------- In 1.4:
------------  FAIL: elaborated into testing of around on all join points()
--- result: false
[  0] ------------  PASS: CompilerRun(CompilerRun.Spec AjdtCommand(1 paths))
[  0] --- result: true
[  0] --- messages 
[  0] MessageHolder:  (5 info) 
[  0] [info   0]: info org.aspectj.ajdt.ajc.AjdtCommand@30af424b([-d, C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes, -classpath, C:\DOCUME~1\gharley\LOCALS~1\Temp\SandboxKD85EM\classes;..\lib\test\aspectjrt.jar;..\lib\test\testing-client.jar, C:\eclipse-21-Release\eclipse\workspace\tests\new\AroundAll.java]) 
[  0] [info   1]: info directory classpath entry does not exist: C:\ibm-sdk-131-sr3\jre\classes 
[  0] [info   2]: info compiling C:\eclipse-21-Release\eclipse\workspace\tests\new\AroundAll.java 
[  0] [info   3]: info weaving 
[  0] [info   4]: info might need to weave [UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\AroundAll.class, AroundAll), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\A.class, A), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\SuperC.class, SuperC), UnwovenClassFile(C:\Documents and Settings\gharley\Local Settings\Temp\SandboxKD85EM\classes\C.class, C)](world=true) 
[  1] ------------  FAIL: JavaRun(JavaRun(AroundAll))
[  1] --- result: true
[  1] --- messages 
[  1] MessageHolder:  (1 info)  (2 fail) 
[  1] [info   0]: info childResult != result=true 
[  1] [fail   0]: fail steps: enter execution(void AroundAll.main(String[])) != enter execution(void AroundAll.main(ClassNotFoundException)) at index 2 
[  1] [fail   1]: fail [ expected steps "enter execution(void AroundAll.main(String[]))" not found,  unexpected steps "enter execution(void AroundAll.main(ClassNotFoundException))" found] 

---------------- 1.3.1 and 1.4 emacssym
------------  FAIL: Ajc 1.1 rc1 java.lang.VerifyError with messy arounds()
--- result: false
[  0] ------------  FAIL: CompilerRun(CompilerRun.Spec AjdtCommand(3 paths 3 messages))
[  0] --- result: false
[  0] --- messages 
[  0] MessageHolder:  (8 info)  (1 error)  (4 fail)  (1 abort) 
[  0] [info   0]: info org.aspectj.ajdt.ajc.AjdtCommand@6c164384([-emacssym, -d, C:\Documents and Settings\gharley\Local Settings\Temp\SandboxK3hKCe\classes, -classpath, C:\DOCUME~1\gharley\LOCALS~1\Temp\SandboxK3hKCe\classes;..\lib\test\aspectjrt.jar;..\lib\test\testing-client.jar, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\aspects\Trace.aj, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\cap\OptionList.java, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\DebugTrace.aj]) 
[  0] [info   1]: info directory classpath entry does not exist: C:\ibm-sdk-131-sr3\jre\classes 
[  0] [info   2]: info compiling C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\aspects\Trace.aj 
[  0] [info   3]: info compiling C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\cap\OptionList.java 
[  0] [info   4]: info compiling C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\DebugTrace.aj 
[  0] [info   5]: info CompilerRun.Spec AjdtCommand(3 paths 3 messages) 
[  0] [info   6]: info [-emacssym, -d, C:\Documents and Settings\gharley\Local Settings\Temp\SandboxK3hKCe\classes, -classpath, C:\DOCUME~1\gharley\LOCALS~1\Temp\SandboxK3hKCe\classes;..\lib\test\aspectjrt.jar;..\lib\test\testing-client.jar, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\aspects\Trace.aj, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\cap\OptionList.java, C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\DebugTrace.aj] 
[  0] [info   7]: info TestSetup(org.aspectj.ajdt.ajc.AjdtCommand ) 
[  0] [error   0]: error Internal compiler error
java.lang.NullPointerException
	at org.aspectj.ajdt.internal.core.builder.AsmBuilder.internalBuild(AsmBuilder.java:125)
	at org.aspectj.ajdt.internal.core.builder.AsmBuilder.build(AsmBuilder.java:64)
	at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.finishedCompilationUnit(EclipseFactory.java:303)
	at org.aspectj.ajdt.internal.compiler.AjCompiler.process(AjCompiler.java:67)
	at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:338)
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java(Compiled Code))
	at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:125)
	at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:101)
	at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:53)
	at org.aspectj.testing.harness.bridge.CompilerRun.run(CompilerRun.java:374)
	at org.aspectj.testing.run.Runner.runPrivate(Runner.java:359)
	at org.aspectj.testing.run.Runner.runChild(Runner.java:159)
	at org.aspectj.testing.run.Runner.runChild(Runner.java:118)
	at org.aspectj.testing.run.Runner$IteratorWrapper.run(Runner.java:438)
	at org.aspectj.testing.run.Runner.runPrivate(Runner.java:359)
	at org.aspectj.testing.run.Runner.runChild(Runner.java:159)
	at org.aspectj.testing.run.Runner.runChild(Runner.java:118)
	at org.aspectj.testing.run.Runner$IteratorWrapper.run(Runner.java:438)
	at org.aspectj.testing.run.Runner.runPrivate(Runner.java:359)
	at org.aspectj.testing.run.Runner.run(Runner.java:106)
	at org.aspectj.testing.run.Runner.run(Runner.java:97)
	at org.aspectj.testing.run.Runner.runIterator(Runner.java:220)
	at org.aspectj.testing.drivers.Harness.run(Harness.java:313)
	at org.aspectj.testing.drivers.FeatureHarness.run(Harness.java:595)
	at org.aspectj.testing.drivers.Harness.runMain(Harness.java:275)
	at org.aspectj.testing.drivers.Harness.main(Harness.java:120)
	at org.aspectj.testing.Harness.main(Harness.java:37)
 at C:\eclipse-21-Release\eclipse\workspace\tests\bugs\messyAround\DebugTrace.aj:0:0
[  0] [fail   0]: fail unexpected  error: error Internal compiler error
java.lang.NullPointerException
	at org.aspectj.ajdt.internal.core.builder.AsmBuilder.internalBuild(AsmBuilder.java:125)
	at org.aspectj.ajdt.internal.core.builder.AsmBuilder.build(AsmBuilder.java:64)
	at org.aspectj.ajdt.internal.compiler.lookup.EclipseFactory.finishedCompilationUnit(EclipseFactory.java:303)
	at org.aspectj.ajdt.internal.compiler.AjCompiler.process(AjCompiler.java:67)
...

George Harley1 wrote:
> 
> Hi,
> 
> Adrian and I have done a first pass at building rc2 today and carried out
> the pre-installation tests. Please take a look at the artifacts in
> org.aspectj/releases/aspectj-1.1rc2 for a record of how things went. A
> breakdown of the files is :-
> 
> * build1.1rc2.log .... the build output
> * junitModules.report.zip .... the zipped up JUnit report from a run of the
> tests/junitModules.xml file (results identical for 1.3.1 and 1.4 JDKs : 6
> errors)
> * ajcTests-result-1.1rc2-JDK[1.3.1 | 1.4].txt .... results of running
> org.aspectj.testing.Harness against ajcTests.xml (results differ between
> 1.3.1 and 1.4 JDKs)
> * ajcTests-result-1.1rc2-emacssym-JDK[1.3.1 | 1.4].txt .... results of
> running org.aspectj.testing.Harness against ajcTests.xml with -emacssym
> switch (results differ between JDKs)
> * ajcTestsFailing-result-1.1rc2-JDK131.txt .... results of running Harness
> against the ajcTestsFailing.xml file (test not carried out on 1.4 JDK yet)
> * ajcTestsFailing-result-1.1rc2-emacssym-JDK131.txt .... results of running
> Harness against ajcTestsFailing.xml with -emacssym switch (test not carried
> out on 1.4 JDK yet)
> 
> FYI, we hit one or two little snags today in the course of carrying out the
> rc2 building activities :-
> 
> * Build
> ----------
> Inside Eclipse (2.1 Release build), we could not carry out a successful Ant
> build against the org.aspectj/modules/build/build.xml file with the ant.jar
> and optional.jar from org.aspectj/modules/lib/ant/lib in the Ant classpath.
> The error was always the same ...
> 
> > Buildfile: C:\eclipse-21-Release\eclipse\workspace\build\build.xml
> > BUILD FAILED: java.lang.VerifyError: (class:
> org/apache/xerces/parsers/IntegratedParserConfiguration, method:
> configurePipeline signature: ()V) Incompatible type for getting or setting
> field
> > Total time: 110 milliseconds
> 
> ...this used to work when we cut rc1. Using the ant.jar and optional.jar
> from the 1.5.2 Ant plugin directory got around it.
> 
> * JUnit Tests
> -------------------
> Inside Eclipse (2.1 Release build) we could not run Ant on the
> org.aspectj/modules/tests/junitModules.xml using any of the jars in
> org.aspectj/modules/lib/ant/lib on the Ant classpath. The only way (and,
> trust me, I tried many) I could get this to work inside Eclipse was to set
> the Ant classpath to incorporate the following jars ...
> 
> + ant.jar and optional.jar from the 1.5.2 Ant Eclipse plugin
> + junit.jar from org.aspectj/modules/lib/junit
> + various jars from the Xalan-J 2.2.0 download that I happened to have
> around (haven't tried against the latest Xalan-J which is 2.5 I think)
> 
> Please could someone confirm that using the current set of jars in
> org.aspectj/modules/lib/ant/lib prevents successful building and JUnit
> testing. Looks like an update to these jars is required in CVS ?
> 
> Best regards,
> George
> ________________________________________
> George C. Harley
> IBM e-Business Integrated Technologies
> MP 146, Hursley Park, Winchester, Hants, UK
> External : +44 (0)1962 819549 / Internal : 7-249549
> Fax : +44 (0)1962 818999
> Email : gharley@xxxxxxxxxx
> Web : http://ibm.com/java
> 
> _______________________________________________
> aspectj-dev mailing list
> aspectj-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/aspectj-dev
References:
- [aspectj-dev] 1.1rc2 building
  - From: George Harley1
Prev by Date: [aspectj-dev] 1.1rc2 building
Next by Date: Re: [aspectj-dev] Incremental Compilation problems.
Previous by thread: [aspectj-dev] 1.1rc2 building
Next by thread: [aspectj-dev] incremental structure models, options
Index(es):
- Date
- Thread
Breadcrumbs
