I just think that as long as a significant number of people are using 1.5 it's silly to break the code just in order to keep it from breaking. :)
On Jul 5, 2011, at 7:54 AM, Urs Frei wrote: Thanks for your code formatting proposal.
We'll install it on our machines and try it out. We agree with your arguments.
Just the thing about the 1.5 Java compiler....
Using @Override for interface implementations
(and turning compiler warnings on ;-)) would help creating better code.
Please let us know as soon as you're ready to use 1.6.
Von:
Miles Parker <milesparker@xxxxxxxxx>
An:
AMP developer mailing
list <amp-dev@xxxxxxxxxxx>
Datum:
04.07.2011 20:10
Betreff:
Re: [amp-dev]
Antwort: Formatting..
Gesendet von:
amp-dev-bounces@xxxxxxxxxxx
On Jul 3, 2011, at 11:49 PM, Urs Frei wrote:
Yes, we should all use the same formatting.
Eclipse-built-in formattting would be okay. But we'd rather prefer using
greater line length for code and comments as we talked about it earlier.
Besides, we'd like to use indentations for switch cases.
We're using only two white spaces instead or tab to win space on display.
But we're open to different preferences. Most important is that all committers
use the same formatting as you mentioned it. And this settings should be
available on git as well!
I agree that we need longer lines (I think 800 is too
many! I use 120.) but we should definitely use tabs for all white space.
I was using four spaces because I thought that was what other projects
were doing but it turns out that now almost everyone is using tabs. For
the 4 vs. 2 spaces, I think that only affects the code presentation, right?
As long as it doesn't change anything about the checked in code, use what
you'd like -- I prefer 4 just because I'm used to it.
1. I also like one blank line before first declaration
because I think it is looks silly without.
2. No NL for empty anonymous.
3. No new line after param tags.
4. Never join lines (this is because so much generated
code relies on where the generator places it and it is really messes up
code comparisons.)
There are some code-formatting changes that I'd like to
enforce as well. For example, one thing that really annoys me is conditional
statements without braces..EMF even generates code like this and it drives
me bonkers..
BTW, we should review the code and change everything to
Java 1.5 that can be, I think the choice of Java 1.6 in places is often
arbitrary. For this reason, I'm still avoiding use of @Override as it unnecessarily
prevents some code from running on Java 1.5.
So there are my modified proposals. If they make sense
to you, I propose we run the code cleanup on all AMP sources and then hopefully
that will get us all on track.
[Anhang "AMP_Formatter.xml"
gelöscht von Urs Frei/FHSG] [Anhang "AMP_Settings_MTP.xml" gelöscht
von Urs Frei/FHSG]
So here comes our proposed settings. See attachment.
Von: Miles
Parker <milesparker@xxxxxxxxx>
An: AMP
developer mailing list <amp-dev@xxxxxxxxxxx>
Datum: 01.07.2011
20:21
Betreff: [amp-dev]
Formatting..
Gesendet von: amp-dev-bounces@xxxxxxxxxxx
Hi, me again...
I'm sure you guys have all noticed that the git and patch revisions deltas
aren't smart enough to ignore white space. At some point in the past all
the source files were set up for 4 spaces as opposed to a tab. Basically
righ now diffs are unreadable as I'm sure you've also noticed. Let's reformat
the entire source code base so that we can start fresh? I'm assuming that
you guys are using the standard formatting.
cheers,
Miles
_______________________________________________
amp-dev mailing list
amp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/amp-dev
________________________________________________________________
Urs Frei, Ingenieur FH
Wissenschaftlicher Mitarbeiter
Fon +41 71 226 12 22
Fax +41 71 226 12 13
Web http://www.fhsg.ch
FHS St.Gallen, Hochschule für Angewandte Wissenschaften
IMS-FHS | Poststrasse 28 | Postfach 1664 | 9001 St.Gallen | Switzerland
FHO Fachhochschule Ostschweiz<AMP_Formatting_Profile.xml>_______________________________________________
amp-dev mailing list
amp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/amp-dev
_______________________________________________
amp-dev mailing list
amp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/amp-dev
________________________________________________________________
Urs Frei, Ingenieur FH
Wissenschaftlicher Mitarbeiter
Fon +41 71 226 12 22
Fax +41 71 226 12 13
Web http://www.fhsg.ch
FHS St.Gallen, Hochschule für Angewandte Wissenschaften
IMS-FHS | Poststrasse 28 | Postfach 1664 | 9001 St.Gallen | Switzerland
FHO Fachhochschule Ostschweiz_______________________________________________ amp-dev mailing list amp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/amp-dev
|