[amp-dev] Antwort: Re: Antwort: PluginProjectWizard

[Jonas Ruettimann <jonas.ruettimann@xxxxxxx>]

OK, I'll remove the @Override annotations.

I want to be able to find all critical
@Override annotations when working in the AMP Java source code. Therefore,
I will change all project specific settings in Eclipse. Instead of the
default compiler, I want the old 1.5 as compiler compliance level. That
way every critical @Override will lead to a compiler error.

This kind of settings are being saved
to the ".settings" directory. Do you think it's a good idea to
add this directory to the version control system? 




Von:      
 Miles Parker <milesparker@xxxxxxxxx>
An:      
 Jonas Ruettimann <jonas.ruettimann@xxxxxxx>
Kopie:      
 amp-dev@xxxxxxxxxxx
Datum:      
 03.02.2011 17:41
Betreff:    
   Re: Antwort:
PluginProjectWizard

---

Yes, please do. The problem is that the automated build
mechanism assumes 1.5. We'd like to be able to build for 1.5 targets as
long as we can. Unfortunately the new Eclipse defaults seem to insert the
@Overides for interfaces so I've come across this one before.

On Feb 2, 2011, at 10:59 PM, Jonas Ruettimann wrote:

@Override as
an Annotation for implementations of interface methods exists since JDK
1.6. I'm guessing you're locally working with 1.6 but compiling with an
older 1.5. 

I personally like using @Override
for implementations of interface methods. It can really help prevent bugs
when changing the signature of an interface. But if the build must run
on 1.5, then I'll remove those annotations. 



Von:        Miles
Parker <milesparker@xxxxxxxxx>
An:        Jonas
Ruettimann <jonas.ruettimann@xxxxxxx>
Kopie:        AMP
developer mailing list <amp-dev@xxxxxxxxxxx>
Datum:        02.02.2011
19:20 
Betreff:        PluginProjectWizard

---

is breaking on the build for some reason, though I think it worked fine
on mine as well. I suspect that the automated build is more strict about
annotations then either of our default compiler settings. Or something
else is wrong. :) 

Error: file /opt/users/hudsonbuild/workspace/amp-nightly/org.eclipse.amp.git/org.eclipse.amp.amf/plugins/org.eclipse.amp.amf.gen.ide/src/org/eclipse/amp/amf/gen/ide/PluginProjectWizard.java,
line 55: The method init(IWorkbench, IStructuredSelection) of type PluginProjectWizard
must override a superclass method
Warning: file /opt/users/hudsonbuild/workspace/amp-nightly/org.eclipse.amp.git/org.eclipse.amp.amf/plugins/org.eclipse.amp.amf.gen.ide/src/org/eclipse/amp/amf/gen/ide/AbstractMWEBuilder.java,
line 196: Map is a raw type. References to generic type Map<K,V>
should be parameterized 


https://hudson.eclipse.org/hudson/job/amp-nightly/931/consoleFull





________________________________________________________________

Jonas Rüttimann
Wissenschaftlicher Mitarbeiter

Fon +41 71 226 12 29
Fax +41 71 226 12 13
Web http://www.fhsg.ch

FHS St.Gallen, Hochschule für Angewandte Wissenschaften
IMS-FHS | Poststrasse 28 | Postfach 1664 | 9001 St.Gallen | Switzerland

Mitglied der FHO Fachhochschule Ostschweiz




________________________________________________________________

Jonas Rüttimann
Wissenschaftlicher Mitarbeiter

Fon +41 71 226 12 29
Fax +41 71 226 12 13
Web http://www.fhsg.ch

FHS St.Gallen, Hochschule für Angewandte Wissenschaften
IMS-FHS |  Poststrasse 28 | Postfach 1664 | 9001 St.Gallen | Switzerland

Mitglied der FHO Fachhochschule Ostschweiz