[albireo-dev] examples plugin nature

[Bruno Haible <haible@xxxxxxx>]

Hi Gordon,

The first thing that did not work for me when checking out the CVS is the
'org.eclipse.albireo.examples' plugin.

Reason: It's created as a "Java Project", and among the dependencies it
has org.eclipse.swt. But I have no project by this name in my workspace (*);
and it might be the same for other people. If this dependency is simply
removed, the code snippet does not compile.

Suggestion: Change it into a "Plugin Project". Then the dependencies are
specified in plugin.xml + META-INF/MANIFEST.MF. And then the user does not
need to have a project named 'org.eclipse.swt'.

In both cases, navigating into SWT at the source level works the same.

OK to commit this (attached patch)?

Bruno


(*) There's no point for me normally to "Import" plugins like SWT into
a workspace of mine, since
  - when imported as binary, there's no difference in functionality
    between having the plugin project and not having it.
  - when imported as source, I can modify the source code. Can be useful
    in the future, but I'm not at this level yet.

PS: I saw you are already using a 3.4 milestone or snapshot build. Same for me.


### Eclipse Workspace Patch 1.0
#P org.eclipse.albireo.examples
--- .classpath	7 Dec 2007 21:16:02 -0000	1.1
+++ .classpath	21 Jan 2008 20:34:51 -0000
@@ -1,8 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
 	<classpathentry kind="src" path="src"/>
-	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
-	<classpathentry combineaccessrules="false" kind="src" path="/org.eclipse.albireo.core"/>
-	<classpathentry combineaccessrules="false" kind="src" path="/org.eclipse.swt"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.4"/>
+	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
 	<classpathentry kind="output" path="bin"/>
 </classpath>
--- .project	7 Dec 2007 21:16:02 -0000	1.1
+++ .project	21 Jan 2008 20:34:51 -0000
@@ -10,8 +10,19 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.ManifestBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.SchemaBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
 	</buildSpec>
 	<natures>
+		<nature>org.eclipse.pde.PluginNature</nature>
 		<nature>org.eclipse.jdt.core.javanature</nature>
 	</natures>
 </projectDescription>
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ build.properties	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,5 @@
+source.. = src/
+output.. = bin/
+bin.includes = plugin.xml,\
+               META-INF/,\
+               .
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ plugin.xml	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.2"?>
+<plugin>
+</plugin>
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ META-INF/MANIFEST.MF	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,10 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: Albireo Plug-in Examples (Incubator)
+Bundle-SymbolicName: org.eclipse.albireo.examples; singleton:=true
+Bundle-Version: 0.0.1
+Require-Bundle: 
+ org.eclipse.albireo.core;bundle-version="0.0.1",
+ org.eclipse.swt;bundle-version="3.4.0"
+Eclipse-LazyStart: true
+Bundle-RequiredExecutionEnvironment: J2SE-1.4