Why did you change _maven.repositories to _remote.repositories?
We are in milestone builds so I don't think changing this is a good idea as that's a significant behavioural change. done while fixing https://bugs.eclipse.org/bugs/show_bug.cgi?id=399806
notice that the while internal package is not included in javadoc, so it is not visible
should EnhancedLocalRepositoryManagerFactory me moved to impl instead of internal.impl? This would require to mark EnhancedLocalRepositoryManager public, which is not ideal, but at least this enhanced local repository manager would have some visible javadoc
any idea?
Regards,
Hervé
Le dimanche 3 février 2013 14:50:16 Benjamin Bentmann a écrit :
Herve Boutemy wrote:
- Log ----------------------------------------------------------------- commit 50e52d72f9f87b7a73de645b639617964ad0c653 Author: Hervé Boutemy <herve.boutemy@xxxxxxx> Date: Sun Feb 3 13:35:17 2013 +0100
improved javadoc
Please note that there is no point in adding links from public/protected code to private/package code other than to create javadoc warnings and non-functional hyperlinks.
What is of interest to end users should be documented on public/protected code (EnhancedLocalRepositoryManagerFactory in this case). So if you want to extend the docs, I suggest to cut&paste relevant bits from EnhancedLocalRepositoryManager over to the *Factory, again, leaving implementation details out of the picture. The doc should focus on behavior, not implementation.
Benjamin _______________________________________________ aether-dev mailing list aether-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/aether-dev
_______________________________________________ aether-dev mailing list aether-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/aether-dev
Thanks,
Jason
---------------------------------------------------------- Jason van Zyl Founder & CTO, Sonatype Founder, Apache Maven
|