Bug 99903 - [1.5][search] range wrong for package-info
Summary: [1.5][search] range wrong for package-info
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 99662
Blocks:
  Show dependency tree
 
Reported: 2005-06-14 04:21 EDT by Dani Megert CLA
Modified: 2005-09-26 10:50 EDT (History)
1 user (show)

See Also:

Attachments
Variables view (8.41 KB, image/png)
2005-06-14 04:22 EDT, Dani Megert CLA 		no flags Details
Patch to fix this issue (3.25 KB, patch)
2005-08-03 05:24 EDT, Frederic Fusier CLA 		no flags Details | Diff
Test cases added to JavaSearchBugsTests (6.54 KB, patch)
2005-08-03 05:27 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-06-14 04:21:08 EDT 
3.1 RC2

range wrong for package-info.

Follow steps in bug 99812 but select 'package-info' ==> only the '@' gets
selected due to the wrong range (see attached picture).
Comment 1 Dani Megert CLA 2005-06-14 04:22:11 EDT 
Created attachment 23034 [details]
Variables view
Comment 2 Olivier Thomann CLA 2005-06-29 20:17:12 EDT 
In fact the interface package-info should not be visible in the outliner.
Comment 3 Olivier Thomann CLA 2005-06-29 20:28:35 EDT 
This is related to bug 99662.
The package-info interface should not be displayed in the outliner, but the
search should not report a question mark in front of the package-info.
Comment 4 Olivier Thomann CLA 2005-06-29 20:29:12 EDT 
Philippe, This would be a good candidate for 3.1.1.
Comment 5 Philipe Mulet CLA 2005-06-30 03:53:52 EDT 
+1 for 3.1.1
Comment 6 Frederic Fusier CLA 2005-06-30 10:25:39 EDT 
see bug 99662 comment 2
Comment 7 Frederic Fusier CLA 2005-08-03 05:24:33 EDT 
Created attachment 25603 [details]
Patch to fix this issue

Note that instead of using package fragment as suggested in bug 99662 comment
2, I have associated package declaration to matches returned by search.
I did not use package fragment because with this model element, editor was not
opened on package-info.java file while selecting match in Search view...
Comment 8 Frederic Fusier CLA 2005-08-03 05:27:12 EDT 
Created attachment 25604 [details]
Test cases added to JavaSearchBugsTests

2 test cases added to verify that search matches have right associated element
while looking for annotations references but also for references inside javadoc
comments.
Comment 9 Frederic Fusier CLA 2005-08-15 15:04:12 EDT 
Patch released in HEAD stream
Comment 10 Frederic Fusier CLA 2005-08-16 10:22:59 EDT 
Patches released in R3_1_maintenance stream
Comment 11 Olivier Thomann CLA 2005-09-20 14:38:06 EDT 
Verified using I20050920-0010 for 3.2M2
Comment 12 Maxime Daniel CLA 2005-09-26 09:50:23 EDT 
Verified for 3.1.1 using build M20050923-1430.