Bug 99605 - [refactoring][refactoring] Move member type to new file does not update type parameters
Summary: [refactoring][refactoring] Move member type to new file does not update type ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC3   Edit
Assignee: Tobias Widmer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-13 06:55 EDT by David Saff CLA
Modified: 2005-06-17 07:59 EDT (History)
2 users (show)

See Also:

Attachments
patch (1.59 KB, patch)
2005-06-15 05:30 EDT, Tobias Widmer CLA 		no flags Details | Diff
patch (2.74 KB, patch)
2005-06-16 05:32 EDT, Tobias Widmer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Saff CLA 2005-06-13 06:55:27 EDT 
In RC2.  Given code:

class Sub extends ArrayList<Sub.Color> {
	static class Color {}
}

Move Member Type to New File on Color.  The type parameter is not updated,
leading to a compile error.
Comment 1 Dirk Baeumer CLA 2005-06-13 18:49:40 EDT 
Normal references to Sub.Color are correctly updated.

Tobias, can you please comment on the reason for this.
Comment 2 Tobias Widmer CLA 2005-06-14 10:22:01 EDT 
Method updateParameterizedTypeReference incorrectly returns if no new type 
parameters are introduced and misses the rewriting.

The easy fix is to let updateTypeReference handle the type arguments as well.
Comment 3 Tobias Widmer CLA 2005-06-15 05:30:08 EDT 
Created attachment 23139 [details]
patch

This patch fixes a regression introduced when fixing bug 97529
Comment 4 Dirk Baeumer CLA 2005-06-16 03:31:40 EDT 
+1 for RC3.

Martin, can you please cast your vote.
Comment 5 Tobias Widmer CLA 2005-06-16 05:32:29 EDT 
Created attachment 23275 [details]
patch
Comment 6 Martin Aeschlimann CLA 2005-06-16 06:00:00 EDT 
new patch is good, +1 for RC3
Comment 7 Tobias Widmer CLA 2005-06-16 08:08:11 EDT 
Fixed > 20050616
Comment 8 Dirk Baeumer CLA 2005-06-17 07:57:56 EDT 
Start verifying...
Comment 9 Dirk Baeumer CLA 2005-06-17 07:59:40 EDT 
Verified on I20050617-0010 given the example in comment #0.