Bug 99397 - Typo in CompletionProposal#isConstructor()
Summary: Typo in CompletionProposal#isConstructor()
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-10 12:11 EDT by Jerome Lanneluc CLA
Modified: 2005-06-16 14:53 EDT (History)
1 user (show)

See Also:


Attachments
Patch to apply on HEAD (729 bytes, patch)
2005-06-12 12:43 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2005-06-10 12:11:24 EDT
I20050610-0010

The @return tag in CompleationProposal#isConstructor() should read:
  @return <code>true</code> if the proposal is a constructor.
instead of
  @return return <code>true</code> if the proposal is a constructor.
Comment 1 Olivier Thomann CLA 2005-06-10 17:13:29 EDT
This is a trivial fix.
Comment 2 Olivier Thomann CLA 2005-06-12 12:43:54 EDT
Created attachment 22871 [details]
Patch to apply on HEAD
Comment 3 Philipe Mulet CLA 2005-06-13 06:45:16 EDT
+1 for RC3

Dirk - just a doc fixup. Pls vote.
Comment 4 Olivier Thomann CLA 2005-06-13 08:39:19 EDT
I thought that doc changes don't require approval.
Comment 5 Dani Megert CLA 2005-06-13 11:53:48 EDT
Approving for 3.1 RC3, so that Olivier can continue.
Comment 6 Olivier Thomann CLA 2005-06-13 11:58:23 EDT
Fixed and released in HEAD.
To verify it, please check the javadoc of the method
CompletionProposal#isConstructor()
Comment 7 Olivier Thomann CLA 2005-06-16 14:53:15 EDT
Verified using N20050616-0010 + JDT/Core HEAD