Bug 99136 - xlint advice not applied appears twice with cflows
Summary: xlint advice not applied appears twice with cflows
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 1.5.0 M4   Edit
Assignee: Andrew J Huff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-09 08:36 EDT by Andrew J Huff CLA
Modified: 2012-04-03 16:07 EDT (History)
0 users

See Also:

Attachments
fix this (3.21 KB, patch)
2005-06-09 09:25 EDT, Andrew J Huff CLA 		aclement: iplog+
Details | Diff
test this (1.90 KB, patch)
2005-06-09 09:26 EDT, Andrew J Huff CLA 		aclement: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew J Huff CLA 2005-06-09 08:36:06 EDT 
////////////// in the following code
aspect A{
  before(): call(* *(..)) && cflow(execution(* *(..))) {}
}
////////////////////////////////////

two "advice not appied" xlint messages are produced, one for the before advice
and one for the cflow within the before advice.
Comment 1 Andrew J Huff CLA 2005-06-09 09:25:29 EDT 
Created attachment 22682 [details]
fix this

Attatched is a patch to fix this by only printing out "advice not applied"
messages at most once per line.

this does though mean that for something like this only one "advice not
applied" message would be produced:

aspect A{
  pointcut empty();
  before(): empty(){}; before(): empty(){};
}
Comment 2 Andrew J Huff CLA 2005-06-09 09:26:22 EDT 
Created attachment 22683 [details]
test this

patch to add a unit test that checks that the above patch is working
Comment 3 Adrian Colyer CLA 2005-08-26 11:55:16 EDT 
integrate patch in M4...
Comment 4 Adrian Colyer CLA 2005-09-02 06:38:47 EDT 
a slight variation on the patch is now checked into the tree and the test passes.
Thanks Andrew :)