Bug 98733 - [templates] probe formatter when applying templates
Summary: [templates] probe formatter when applying templates
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P4 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-07 13:02 EDT by Tom Hofmann CLA
Modified: 2005-06-10 12:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hofmann CLA 2005-06-07 13:02:15 EDT 
N20050607

see bug 98037 - basically, in order to get template formatting right, we have to
probe the different formatter kinds in a specified order. Fix is trivial -
format using K_EXPRESSION, K_STATEMENTS and K_UNKWOWN until the formatter finds
something to format, e.g. returns a non-null edit.

3.1 candidate.
Comment 1 Olivier Thomann CLA 2005-06-07 13:05:31 EDT 
Also look at bug 98161.
I don't think JDT/Core should change anything. So I might close bug 98161 as
INVALID.
Comment 2 Tom Hofmann CLA 2005-06-07 13:14:44 EDT 
No regression and not high priority. Not critical for 3.1, but nice2have if
timePermitting.
Comment 3 Dani Megert CLA 2005-06-07 13:41:33 EDT 
Fix is trivial approving for 3.1 RC2 (time permitting).
Comment 4 Tom Hofmann CLA 2005-06-08 09:42:41 EDT 
fixed > 20050608
Comment 5 Tobias Widmer CLA 2005-06-10 12:01:00 EDT 
Verified using I20050610-0010