Bug 97547 - [search] Package search does not find references in member types import clause
Summary: [search] Package search does not find references in member types import clause
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC3   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-31 11:54 EDT by Maxime Daniel CLA
Modified: 2005-06-16 11:13 EDT (History)
1 user (show)

See Also:

Attachments
Patch to fix this issue (1.10 KB, patch)
2005-06-13 08:21 EDT, Frederic Fusier CLA 		no flags Details | Diff
Test case added to JavaSearchBugsTests (4.18 KB, patch)
2005-06-13 08:25 EDT, Frederic Fusier CLA 		no flags Details | Diff
Modified jclMin1.5.jar (5.56 KB, application/octet-stream)
2005-06-13 08:27 EDT, Frederic Fusier CLA 		no flags Details
Modified jclMin1.5src.zip (3.50 KB, application/octet-stream)
2005-06-13 08:27 EDT, Frederic Fusier CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2005-05-31 11:54:35 EDT 
Build I20050527-1300.
Create package p.
Create types X and Y as follows:
---- X
package p;
public interface X {
	public interface X1 {
	}
}
---- Y
package p;
import p.X.*;      // (a)
public class Y { 
}

Launch a search on package p's references. Returns 0.

As a side effect, a rename refactoring action on p fails to update line (a)
in Y.
Comment 1 Frederic Fusier CLA 2005-06-13 08:21:23 EDT 
Created attachment 22908 [details]
Patch to fix this issue

Package reference locator *always* needs to verify if import reference tokens
may match pattern prefix as it was done for type references.
Currently it's only only when import reference is not on demand or is static.
Comment 2 Frederic Fusier CLA 2005-06-13 08:25:13 EDT 
Created attachment 22909 [details]
Test case added to JavaSearchBugsTests

Note that this test case requires to change jclMin1.5.jar and jclMin1.5src.zip
files.
I'll attach them to this bug
Comment 3 Frederic Fusier CLA 2005-06-13 08:27:29 EDT 
Created attachment 22910 [details]
Modified jclMin1.5.jar
Comment 4 Frederic Fusier CLA 2005-06-13 08:27:59 EDT 
Created attachment 22911 [details]
Modified jclMin1.5src.zip
Comment 5 Philipe Mulet CLA 2005-06-13 12:06:37 EDT 
+1 for RC3

Dirk - pls vote for this one. See impact on refactoring
Comment 6 Frederic Fusier CLA 2005-06-13 12:09:35 EDT 
I've run JDT-UI tests (refactoring & automated) and they all pass...
Comment 7 Dirk Baeumer CLA 2005-06-13 17:41:31 EDT 
+1.
Comment 8 Frederic Fusier CLA 2005-06-14 12:35:25 EDT 
Fixed and released in HEAD.
Comment 9 Maxime Daniel CLA 2005-06-16 10:50:53 EDT 
Verified using build N20050616-0010 + JDT Core HEAD.