Description Maxime Daniel 2005-05-31 05:21:10 EDT

Two suggestions here:
- unnecessaryTypeCheck, as suggested by the warning name explanation itself,
would probably be a better name that uselessTypeCheck; in terms of conveyed
semantics on  the one hand; for the sake of homogeneity on the other hand (e.g.
with unnecessaryElse in the warning names, and with the UI, which says
unnecessare cast of instanceof);
- this applies to both casts and instanceof operations; I would contend that in
the context of a progressive adoption of parametrized types, unnecessary casts
will be numerous, and that it might be better to be able to activate the
matching warning independently from the checking of instanceof; this said, a new
unnecessaryCast category would be welcome, that would probably more intuitively
relate to cast operations than TypeCheck in the user's mind.