Bug 97326 - [dom] ITypeBinding#isFromSource() is always false for type variables, wildcards, and capture types
Summary: [dom] ITypeBinding#isFromSource() is always false for type variables, wildcar...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-30 13:44 EDT by Markus Keller CLA
Modified: 2005-09-26 12:08 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-05-30 13:44:27 EDT 
I20050527-1300

ITypeBinding#isFromSource() is currently always false for type variables,
wildcards, and capture types. Javadoc tells a different story.

I would expect true iff a type variable or a capture binding originates from
source. For wildcards, I guess the query should always return false (since
wildcard bindings are the same whether they're from source or from binary). The
javadoc should tell that.
Comment 1 Olivier Thomann CLA 2005-06-07 11:46:20 EDT 
Do you need it for RC2?
Comment 2 Markus Keller CLA 2005-06-07 12:14:20 EDT 
No, that's not too urgent for me.
Comment 3 Olivier Thomann CLA 2005-06-07 12:55:16 EDT 
Do you need it for 3.1?
Comment 4 Markus Keller CLA 2005-06-07 13:28:28 EDT 
No, I don't need it for 3.1.

I saw that Martin often uses the query in quick fixes, but since there was no PR
for this so far, I guess all our code works around it or doesn't call
isFromSource() on such bindings.
Comment 5 Olivier Thomann CLA 2005-06-29 20:31:28 EDT 
Philippe, we might want to fix this for 3.1.1
Comment 6 Philipe Mulet CLA 2005-06-30 03:53:16 EDT 
Agreed, need to assess UI side consequences if any.
Comment 7 Olivier Thomann CLA 2005-06-30 11:50:57 EDT 
Markus, is it ok to fix this for 3.1.1?
Comment 8 Markus Keller CLA 2005-06-30 13:25:42 EDT 
> Markus, is it ok to fix this for 3.1.1?
Yes, no problem as long as tests stay green ;-)
Comment 9 Olivier Thomann CLA 2005-07-05 13:56:34 EDT 
Fixed and released in 3.1 maintenance stream.
Adapted existing tests.
Comment 10 Jerome Lanneluc CLA 2005-08-09 12:49:47 EDT 
Verified with 3.2 M1
Comment 11 Maxime Daniel CLA 2005-09-26 11:48:13 EDT 
Verified for 3.1.1 using build M20050923-1430 (verified test cases).
Comment 12 Olivier Thomann CLA 2005-09-26 12:08:27 EDT 
Verified.