Bug 97027 - [override marker] Incorrect override method marker
Summary: [override marker] Incorrect override method marker
Status: RESOLVED DUPLICATE of bug 100233
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-27 12:56 EDT by Kent Johnson CLA
Modified: 2005-08-09 03:26 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Johnson CLA 2005-05-27 12:56:36 EDT
In this case BB.test does not override AA.test, but its tagged in the editor 
that it does.

class AA<T> {
	public AA<Object> test() { return null; }
}
class BB extends AA<CC> {
	public <T> BB test() { return null; }
}
class CC {}
Comment 1 Dirk Baeumer CLA 2005-05-27 13:02:14 EDT
The editor uses the info provided by the bindings. But moving to text to make sure.
Comment 2 Dani Megert CLA 2005-05-30 03:41:32 EDT
I'm using the helper methods from JDT UI. Same problem with override decorator.
Comment 3 Dirk Baeumer CLA 2005-05-30 03:44:34 EDT
Martin, can you please have a look and move on the JDT/Core if we simply call
the methods on core. 
Comment 4 Martin Aeschlimann CLA 2005-05-30 06:12:33 EDT
we're still using our homebrewed 'override' check. Markus, what are the latest
news on 'MethodBinding.overrides()' ?
Comment 5 Markus Keller CLA 2005-05-30 07:02:23 EDT
No news lately. Methods IMethodBinding#overrides(..) and #isSubsignature(..) are
currently not used because they don't work across binding environments. However,
they're implemented and should work for bindings from one compiler loop, but
they have not been tested "in the field".
Comment 6 Martin Aeschlimann CLA 2005-06-01 08:28:58 EDT
We should try to switch and use the jdt.core infrastructure here.
Comment 7 Martin Aeschlimann CLA 2005-06-06 11:46:54 EDT
fixed > 20050606
Comment 8 Markus Keller CLA 2005-06-06 14:17:08 EDT
I've reverted the change in Bindings.findOverriddenMethodInType(..), since it
cause 4 failing TypeMismatchQuickFixTests. The old implementation did not check
return types, but IMethodBinding#overrides(..) does. 
Comment 9 Martin Aeschlimann CLA 2005-06-08 11:16:04 EDT
not for 3.1. IMethodBinding.override is not yet used, its too late to start
testing this now.
Comment 10 Dirk Baeumer CLA 2005-06-23 05:56:02 EDT
Martin, we should investigate whether this can be fixed for 3.1.1. A similar bug
is 100233. We should either switch to the core method here (which results in
some fuzzyness we had regarding the return type) or add this case to the
Bindings implementation we have right now.
Comment 11 Dirk Baeumer CLA 2005-07-11 06:03:07 EDT
Martin, Markus can you please coordinate the fix for 97927 & 100233. IMO they
will affect the same method(s) in class Bindings.
Comment 12 Martin Aeschlimann CLA 2005-07-12 10:44:59 EDT
I suggest we do the fix as suggested in bug 100233. IMO, changing to
IMethodBinding.override for 3.1.1 is not an option.
Comment 13 Dirk Baeumer CLA 2005-08-08 06:28:55 EDT
Martin, I opt to mark this one as a dup of 100233 if we agree on fixing 100233
for 3.1.1.
Comment 14 Martin Aeschlimann CLA 2005-08-09 03:26:25 EDT

*** This bug has been marked as a duplicate of 100233 ***