Community
Participate
Working Groups
I20050527 This morning I opened an existing workspace that was compiling fine yesterday (I did not try to run it and it was not the point), and I've noticed that it was no longer compiling because the type I was refering was "not accessible due to access restrictions". It tooks me a second or two before thinking that it could be that the plugin providing the type was not exporting the proper package. I fixed the package export and everything worked. Trivial. However I think for new comers to eclipse or even long time users this is not trivial. This problem must have a quick fix guiding the users on things that can be done to solve the problem. I mark as major since to me this is a major usability issue
a quickfix is not major. It is an enhancement at best.
I agree that what I want is an enhancement, however it is a major enhancement, because this error will cause the users to scratch their heads many times before they can actually figure out what needs to be changed.
adam adam adam :D
Created attachment 77409 [details] patch Adds a quickfix when: 1) The source project is a plug-in project. 2) The unaccessible node resolves to a plug-in project in the workspace. 3) The package containing the unaccessible node is not exported in the MANIFEST.MF. The one thing I'm not sure about is if JDT will dispose the quickfix icon that I provide. I expect that they should and, therefore, have not bothered to do it myself, but we need to confirm this.
Chris, can you review this one?
will do, this one looks like fun.
Created attachment 77492 [details] patch Turns out JDT does not dispose the Image for us. Unfortunately, because there is no life cycle management on the proposal interface, we have to use the ImageRegistry.
Created attachment 77493 [details] patch In the last patch, I changed the other use of the same image to use the copy in the registry, but I forgot to remove the code that disposes it. This one's good.
Great job Adam. This is easily one of the greatest PDE quickfixes ever. I only found a small issue where you would have multiple quickfixes if you had two access restriction notices on something like MyClass.MyStaticField. We want to make sure that we don't present duplicate quickfixes for exporting the same package. I also did some patch cleanup. Thanks again Adam, this one was a good one.
Created attachment 77605 [details] mylyn/context/zip
