Bug 96794 - Polishing disassembler output
Summary: Polishing disassembler output
Status: CLOSED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-26 10:33 EDT by Philipe Mulet CLA
Modified: 2005-06-10 08:55 EDT (History)
0 users

See Also:


Attachments
Apply on HEAD (28.32 KB, patch)
2005-05-30 21:33 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2005-05-26 10:33:55 EDT
Build 3.1m7

1. in COMPACT mode, it should compact field access return types and thrown
exceptions.
    public static void main(String[] arg) throws java.lang.Exception;
  should be:
    public static void main(String[] arg) throws Exception;

    14 getstatic System.out Ljava/io/PrintStream; [36]
  should be:
    14 getstatic System.out : PrintStream; [36]

  [also note ':' to separate field from return type]

2. on method invocations, the return type should be appended at the end, instead
of leading the method name.
     7 invokevirtual Object X.create() [30]
  should be:
     7 invokevirtual X.create() : Object [30]
Comment 1 Olivier Thomann CLA 2005-05-26 10:48:29 EDT
    52  astore [local_5]

should be:

    52  astore 5  (if no name) 
    52  astore 5 [value] (if there is a name)
Comment 2 Olivier Thomann CLA 2005-05-30 21:33:53 EDT
Created attachment 22001 [details]
Apply on HEAD

Let me know if this is what you expect. Then I will update all the tests that
are comparing a disassembled output.
Comment 3 Philipe Mulet CLA 2005-05-31 04:35:57 EDT
Looks good to me.
Comment 4 Olivier Thomann CLA 2005-05-31 11:26:34 EDT
Fixed and released in HEAD.
All related tests have been updated.
Comment 5 Frederic Fusier CLA 2005-06-07 13:48:37 EDT
Verified for 3.1 RC2 using build N20050607-0010 + JDT/Core HEAD
Comment 6 David Audel CLA 2005-06-10 08:55:44 EDT
Verified for 3.1 RC2 using build I20050610-0010