Bug 95785 - [5.0] Content assist for Collection#toArray(T[]) does not show additional info
Summary: [5.0] Content assist for Collection#toArray(T[]) does not show additional info
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: Tom Hofmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-18 11:38 EDT by Markus Keller CLA
Modified: 2005-05-30 06:32 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-05-18 11:38:26 EDT 
N20050518-0010 (also with HEAD of JDT/UI and JDT/Core)

- have 'Fill argument names on completion' and 'Guess filled method arguments'
enabled

- in the method below (in a 5.0 project), execute contant assist after toArray
and choose "toArray(Object[] a)":
    public void test(java.util.List aList){
        aList.toArray
    }

=> There's not javadoc for this method
=> the line now reads:
        aList.toArray(toarray - convert collection to array)

- changing the parameter type to List<Object> splits the proposal in two and
emits a beep when the proposals are inserted:
  - toArray(T[]) T[] - Collection
  - toArray(T[]) T[] - List
=> Expected: only the one from List is proposed; no beep.
Comment 1 Tom Hofmann CLA 2005-05-18 15:08:13 EDT 
1) missing additional info
- fix is ready for 20050519

2) toarray template added as first proposal, beep
- keeping this PR for this issue

3) toArray proposed twice:

filed bug 95829 against jdt-core.
Comment 2 Dani Megert CLA 2005-05-18 15:42:04 EDT 
>1) missing additional info
>- fix is ready for 20050519

Approving fix for 1) for RC1: adapting summary: Markus, you know the rules ;-)
one PR per report, especially know where we must have a PR with the correct
target milestone and an approval.

Please file a separate bug report for the beep issue.
Comment 3 Markus Keller CLA 2005-05-19 04:55:28 EDT 
Sorry, filed bug 95908 for 2).
Comment 4 Tom Hofmann CLA 2005-05-26 12:55:39 EDT 
I propose to not propose the toArray template at all as it is not that helpful
anyway.
Comment 5 Markus Keller CLA 2005-05-27 03:00:36 EDT 
Tom, doesn't your comment 4 belong to bug 95908?
I find the toArray proposal very helpful in general, just not in that context.
Comment 6 Tom Hofmann CLA 2005-05-27 03:07:12 EDT 
yes, you're right of course. I just meant to not propose 'toarray' as a
parameter guess. The normal template will not be affected.
Comment 7 Tom Hofmann CLA 2005-05-27 12:40:33 EDT 
fixed for RC1
Comment 8 Dani Megert CLA 2005-05-30 06:20:01 EDT 
start verifying.
Comment 9 Dani Megert CLA 2005-05-30 06:32:33 EDT 
Verified 1) in 3.1 RC1.