Bug 95619 - [5.0][content assist] Function parameter assist does not work with some parameterized types
Summary: [5.0][content assist] Function parameter assist does not work with some param...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux
: P2 normal with 1 vote (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Tom Hofmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 140730 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-05-17 14:05 EDT by Luke Hutchison CLA
Modified: 2006-05-10 03:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Hutchison CLA 2005-05-17 14:05:57 EDT 
If I have a function like

  private int fn(HashMap <String,HashMap<String,Integer[]>> map, int p1, float
p2) { }

then when the parameter assist pops up when I call fn(), it interprets the
commas in the parameterized type as commas that separate parameters, so the
following are highlighted (bolded), in order, as if they are parameters:

HashMap <String
HashMap<String
Integer[]>> map
int p1
float p2

What should happen is that angle brackets should hierarchically "escape" comma
interpretation.
Comment 1 Dani Megert CLA 2005-05-18 15:46:26 EDT 
Tom, is this hard to fix? See also bug 93121.
Comment 2 Tom Hofmann CLA 2005-05-18 16:01:38 EDT 
The JavaParameterListValidator has some issues with nesting: array initializers,
generic signatures. 

Not hard to fix - 0.5d including tests.
Comment 3 Dani Megert CLA 2006-03-15 10:11:53 EST 
Polish list item.
Time permitting for M6, RC1 otherwise.
Comment 4 Tom Hofmann CLA 2006-04-11 06:01:56 EDT 
fixed > 20060411

Using the newly introduced JavaHeuristicScanner.lookslikeClassInstanceCreationBackward predicate to detect generic class instance creations in method calls.

Use scoping to handle arrays.
Comment 5 Johannes Rieken CLA 2006-04-26 13:05:17 EDT 
verified in 20060426
Comment 6 Tom Hofmann CLA 2006-04-27 04:22:49 EDT 
see comment 5
Comment 7 Tom Hofmann CLA 2006-05-10 03:38:15 EDT 
*** Bug 140730 has been marked as a duplicate of this bug. ***