Bug 95152 - [search] F3 can't find synthetic constructor
Summary: [search] F3 can't find synthetic constructor
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 122880 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-05-13 12:14 EDT by John Arthorne CLA
Modified: 2006-09-11 12:53 EDT (History)
1 user (show)

See Also:

Attachments
First draft to fix this problem (11.03 KB, application/octet-stream)
2006-04-26 11:48 EDT, Frederic Fusier CLA 		no flags Details
Complete patch (fix+tests) for bugs 95152, 123679 and 140156 (14.31 KB, application/octet-stream)
2006-05-12 03:51 EDT, Frederic Fusier CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2005-05-13 12:14:28 EDT 
Build: I20050513-0010

1) Add org.eclipse.debug.ui to the search path (i.e., by clicking "Add to Java
Search" in the plugins view.
2) Open type on "ProcessConsole" (class file with source attached)
3) Go to line 483:

        InputReadJob readJob = new InputReadJob(streamsProxy);

4) Highlight the InputReadJob constructor and hit F3.

-> It opens a new class file editor, positioned at the top of the file.

5) The outline view in this editor has the constructor
InputReadJob(ProcessConsole, IStreamsProxy).  Clicking this entry in the outline
view does not jump to the constructor in the editor.

The mapping of class file to source is not handling the synthetic addition of
the enclosing class by the compiler.  This breaks any kind of navigation to the
corresponding constructor in the source attachment.
Comment 1 Frederic Fusier CLA 2005-05-30 05:12:09 EDT 
This is a search issue as looking for this constructor reference does not report
any match.
Comment 2 Frederic Fusier CLA 2006-03-28 13:02:57 EST 
*** Bug 122880 has been marked as a duplicate of this bug. ***
Comment 3 Frederic Fusier CLA 2006-04-26 11:48:44 EDT 
Created attachment 39544 [details]
First draft to fix this problem

Main problem is fixed with this patch but there are still some unresolved side effects while running JDT/Core Model tests
Comment 4 Frederic Fusier CLA 2006-04-26 11:49:36 EDT 
I'll continue to work on this and so reopen this bug for next release...
Comment 5 Frederic Fusier CLA 2006-05-12 03:49:41 EDT 
Complete fix which passes all test is now ready => reopen
Comment 6 Frederic Fusier CLA 2006-05-12 03:51:19 EDT 
Created attachment 41285 [details]
Complete patch (fix+tests) for bugs 95152, 123679 and 140156

The attached zip file includes patches for bug 95152, bug 123679 and bug 140156.
It also includes some jar files for binary test cases...

Note that all JDT/Core and JDT/UI pass with these fixes.
Comment 7 Frederic Fusier CLA 2006-05-16 08:57:26 EDT 
Candidate for 3.2.1
Released in TARGET_321 stream.
Comment 8 Frederic Fusier CLA 2006-06-12 05:13:48 EDT 
Released for 3.2.1
Released for 3.3 M1 while merging TARGET_321 with HEAD
Comment 9 Maxime Daniel CLA 2006-08-04 08:09:25 EDT 
Failed on a test case inspired by duplicate bug 122880, failed. Discussed with Frédéric who found out that this is not completely fixed yet.
Comment 10 Frederic Fusier CLA 2006-08-04 11:14:02 EDT 
I introduced a regression while adding fix for bug 123679 and unfortunately it was not detected by the tests I added.
This is now fixed, tests updated and everything released again in both R3_2_maintenance and HEAD streams
Comment 11 Frederic Fusier CLA 2006-08-07 03:42:14 EDT 
Verified for 3.3 M1 using build I20060807-0010
Comment 12 Olivier Thomann CLA 2006-09-11 11:53:18 EDT 
Verified for 3.2.1 using build M20060908-1655.