Bug 95096 - [5.0][content assist] Content assist popup disappears while completing the statically imported method name
Summary: [5.0][content assist] Content assist popup disappears while completing the st...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.1.1   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 108514 (view as bug list)
Depends on: 97307
Blocks:
  Show dependency tree
 
Reported: 2005-05-13 06:16 EDT by Tobias Widmer CLA
Modified: 2005-09-02 11:38 EDT (History)
3 users (show)

See Also:

Attachments
JavaMethodCompletionProposal.java.diff (1.16 KB, patch)
2005-09-01 13:11 EDT, Tom Hofmann CLA 		no flags Details | Diff
LazyJavaCompletionProposal.java.diff (1.72 KB, patch)
2005-09-02 05:19 EDT, Tom Hofmann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Widmer CLA 2005-05-13 06:16:38 EDT 
I20050513-0010

Steps to reproduce:
- Create a new Class "Foo"
- Type "import static java.lang.Math."
- Press Ctrl+Space
- Type "a"

-> Instead of constraining the proposals to all members with prefix a, the 
popup closes
Comment 1 Dani Megert CLA 2005-05-13 06:19:16 EDT 
Tom, please investigate.
Comment 2 Dani Megert CLA 2005-05-30 12:18:30 EDT 
Time permitting for RC2.
Comment 3 Tom Hofmann CLA 2005-06-01 05:34:58 EDT 
Different phenomenon showing the same problem: the replaceStart and replaceEnd
properties of METHOD_NAME_REFERENCE proposals are not set.

*** This bug has been marked as a duplicate of 97307 ***
Comment 4 Tom Hofmann CLA 2005-06-01 09:33:22 EDT 
Not a dup, but only dependent - now the problem is that the display name for
static imports does not match the completion (which is fully qualified). A fix
would extend validate() in JavaMethodCompletionProposal and allow qualified
matches similar to LazyJavaTypeCompletionProposal.
Comment 5 Dani Megert CLA 2005-06-09 11:23:27 EDT 
Deferred.
Comment 6 Dani Megert CLA 2005-09-01 05:26:30 EDT 
*** Bug 108514 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2005-09-01 05:29:24 EDT 
Tom, please investigate a fix for 3.1.1.
Comment 8 Tom Hofmann CLA 2005-09-01 13:11:21 EDT 
Created attachment 26765 [details]
JavaMethodCompletionProposal.java.diff

patch that fixes the static imports problem. Does not fix a similar problem
when completing types in javadoc (e.g. within @see tags).
Comment 9 Tom Hofmann CLA 2005-09-01 13:11:42 EDT 
released this to HEAD, leaving open for 3.1.1.
Comment 10 Tom Hofmann CLA 2005-09-02 05:19:22 EDT 
Created attachment 26789 [details]
LazyJavaCompletionProposal.java.diff

real patch - this patch checks for METHOD_NAME_REFERENCE proposals and
validates these differently.

The other patch is still valid (changes the auto-insertion triggers for
METHOD_NAME_REFERENCE proposals), but not crucial for 3.1.1.

Released to HEAD.
Comment 11 Dani Megert CLA 2005-09-02 06:48:52 EDT 
Verified patch.
Committed and released into R3_1_maintenance.
Comment 12 Dirk Baeumer CLA 2005-09-02 11:32:16 EDT 
start verifying...
Comment 13 Dirk Baeumer CLA 2005-09-02 11:38:14 EDT 
Verified the code assist behaves correctly in static and non static import
statements. 

Verified on M20050831-1200