Bug 95051 - [nls tooling][navigation] Usage search from property editor doesn't find references from JavaDoc
Summary: [nls tooling][navigation] Usage search from property editor doesn't find refe...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2005-05-12 17:50 EDT by Eugene Kuleshov CLA
Modified: 2006-03-21 04:58 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2005-05-12 17:50:14 EDT
When searching for usages from Java properties editor (F3 or ctrl-click) it
doesn't find property references used inside JavaDoc comments. Such properties
are often used for JavaDoc-based annotations (e.g. with QDox or XDoclet tools)
and it will be a good idea to see those references in the search results.
Comment 1 Dani Megert CLA 2005-05-13 09:02:27 EDT
Can you give an example? The current support only covers NLS properties.
Comment 2 Eugene Kuleshov CLA 2005-05-13 10:26:30 EDT
Ok. I have dozen of projects that has project.properties at the project root
directory where we define all substitution variables (e.g. EJB pool sizes, JDNI
names, etc). Our build is using XDoclet (btw, it is the same metadata generator
as used by Eclipse WTP) and you can write something like this:

/**
 * Mdb1Bean
 * 
 * @ejb.bean 
 *   name="Mdb1Bean" 
 *   type="MDB"
 *   destination-type="javax.jms.Queue" 
 *   transaction-type="Container"
 *
 * @ejb.transaction type="Required"
 * 
 * @weblogic.transaction-descriptor
 *   trans-timeout-seconds="${javatx.tx.timeout}" 
 * 
 * @weblogic.message-driven 
 *   initial-context-factory="${javatx.mdb1.icf}" 
 *   provider-url="${javatx.mdb1.url}"   
 *   connection-factory-jndi-name="${javatx.mdb1.qcf}" 
 *   destination-jndi-name="${javatx.mdb1.queue1}"
 *   jms-polling-interval-seconds="${javatx.mdb1.pooling.interval}"
 *   
 * @weblogic.pool
 *   initial-beans-in-free-pool="${javatx.mdb1.pool.initial}" 
 *   max-beans-in-free-pool="${javatx.mdb1.pool.max}"
 *     
 * @author Eugene Kuleshov
 */
public class Mdb1Bean extends BaseMdb {

  protected void onMessageImpl( Message message) {
    try {
      String messageId = message.getJMSMessageID();
      logger.info( messageId+" : "+message);
      
    } catch( JMSException ex) {
      Locator.logError( "JMS error", ex);
    
    }
  }

}

Notice that all ${...} tokens will be substituted with values from propery file
I mentioned above and then XDoclet will generate deployment descriptors from
this JavaDoc metadata.

Basically what I'm asking is that property usage search should find these
substitutions.
Comment 3 Dani Megert CLA 2005-05-13 11:09:42 EDT
So you're basically using it for any key/value pair unrelated to NLSing, right? 

Currently the whole support is built around property files that contain
externalized strings. We have to investigate whether it's feasible to open this up.
Comment 4 Eugene Kuleshov CLA 2005-08-29 16:06:49 EDT
Daniel, is there are any chance to address this in 3.2?
Comment 5 Dani Megert CLA 2006-03-21 04:58:57 EST
>Daniel, is there are any chance to address this in 3.2?
Not for 3.2.