Bug 94951 - [implementation] Compiler error prevents further development
Summary: [implementation] Compiler error prevents further development
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC1   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-12 09:16 EDT by Philipe Mulet CLA
Modified: 2005-05-30 06:03 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2005-05-12 09:16:00 EDT 
Build 20050509

JDT/Text counterpart of bug 94945.
See steps in other PR.
Comment 1 Dani Megert CLA 2005-05-12 09:28:50 EDT 
I verified that we handle IllegalStateException gracefully when we call
ASTParser.createAST(...).

I'm not yet sure whether we should catch RuntimeException in our code. The
current pattern in Eclipse is not to do so, e.g. content providers: if there's
some code let's say in IJavaElementDelta.getElement() that has bugs (e.g. NPE)
then you get a dialog each time a delta is sent - no code that wraps this with
catching RuntimeException.
Comment 2 Dani Megert CLA 2005-05-12 09:38:14 EDT 
Will use safe-runnable in Java reconciler and ASTProvider.
Comment 3 Dani Megert CLA 2005-05-20 10:43:52 EDT 
Fixed in HEAD.
Comment 4 Dani Megert CLA 2005-05-30 06:01:01 EDT 
start verifying
Comment 5 Dani Megert CLA 2005-05-30 06:03:07 EDT 
Verified in 3.1 RC1 by changing the client code to throw an exception.