Bug 93842 - I18N: Core model messages should not be concatenated
Summary: I18N: Core model messages should not be concatenated
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.1   Edit
Assignee: Markus Schorn CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-05-05 15:40 EDT by Tanya Wolff CLA
Modified: 2008-06-19 13:26 EDT (History)
1 user (show)

See Also:


Attachments
patch for HEAD (1.12 KB, patch)
2005-09-14 07:45 EDT, Vaidotas Radžius CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tanya Wolff CLA 2005-05-05 15:40:58 EDT
This question came from the translation team.  
>File  
>eclipse\plugins\org.eclipse.cdt.core\cdtcore_jar\org\eclipse\cdt\internal\core\model\CoreModelMessages.properties

>Can you please clarify these strings? The end of the string seems to be
missing. >Are they to be combined with some other string? 
>
>PathEntryManager.1=Workspace include path in accessible 
>PathEntryManager.7=Workspace library path in accessible 

There are 2 problems here. "in accessible" should be "inaccessible."
and it should not be concatentated in pathEntryUtil.java. There are several
occurrences of concatenation in the file, here is one instance: 

CoreModelMessages.getString("PathEntryManager.7") + " (" +
libraryPath.toOSString() + ")");  //$NON-NLS-1$//$NON-NLS-2$//$NON-NLS-3$

Use MessageFormat instead, and externalize the brackets especially for Arabic
translation.
Eg:
Change the getString call to getFormattedString: 
 
CoreModelMessages.getFormattedString("PathEntryManager.7",libraryPath.toOSString()));

and change CoreModelMessages.properties:

PathEntryManager.7=Workspace library path inaccessible ({0})
Comment 1 Vaidotas Radžius CLA 2005-09-14 07:45:53 EDT
Created attachment 27105 [details]
patch for HEAD

Fixes described string and others same strings found in file
pathentryutils.java
Comment 2 Vaidotas Radžius CLA 2005-09-14 07:47:07 EDT
Please apply suplied patch and close this issue
Comment 3 Markus Schorn CLA 2006-05-15 05:28:46 EDT
Thanks Vaidotas, I have applied the patch.
Comment 4 Doug Schaefer CLA 2008-06-03 14:23:53 EDT
assigning
Comment 5 Doug Schaefer CLA 2008-06-03 14:24:13 EDT
done.
Comment 6 Markus Schorn CLA 2008-06-05 06:43:32 EDT
Fixed in 2006.