Bug 93517 - Incorrect advice markers are used if the advising aspect is binary
Summary: Incorrect advice markers are used if the advising aspect is binary
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: 1.2.0 M3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.2.1   Edit
Assignee: Sian January CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-03 08:33 EDT by Sian January CLA
Modified: 2005-11-10 05:32 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sian January CLA 2005-05-03 08:33:09 EDT 
If an aspect advising a class is binary (e.g in a jar on the aspect path) we 
see generic advice markers in the class, regardless of which type of advice is 
in effect.  We should see either before, after or around advice markers (with 
the runtime test decorator if there is a runtime test), depending on the type 
of advice.  The generic marker should only be used if there are different 
types of advice in effect on the same line.
Comment 1 Sian January CLA 2005-11-10 05:32:18 EST 
Now fixed  - added the IProgramElement.ExtraInformations to the 
AJInjarElements so that the MarkerUpdating class can tell the type of advice. 
Fixed in the following builds:

AJDT 1.2.1 for Eclipse 3.0:
BUILD COMPLETE -  build.570
Date of build: 11/09/2005 15:59:27
Time to build: 79 minutes 17 seconds

AJDT 1.3.0 for Eclipse 3.1:
BUILD COMPLETE -  build.179
Date of build: 11/09/2005 14:41:23
Time to build: 75 minutes 41 seconds

Unfortunately this fix doesn't help with the icons for @AspectJ relationships 
mentioned in bug 101412.