Bug 93105 - Remove unnecessary APIs on BindingKey
Summary: Remove unnecessary APIs on BindingKey
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-28 07:14 EDT by Jerome Lanneluc CLA
Modified: 2005-05-12 11:20 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2005-04-28 07:14:02 EDT 
I20050426-1700

After discussions with JDT/UI, we came to conclusion that the following 3.1 APIs
on BindingKey are not suitable; since they may cache element structural
information into keys, leaving  clients with difficult decisions as to whether
to trust the key or the element.

- BindingKey#getDeclaringTypeSignature()
- BindingKey#toSignature()

The only interest for having these APIs on the key is to cache some information
avoiding populating the model, and is not mandated by the normal binding key
contract, i.e. identify uniquely a type binding. 

Therefore, they should not be added . If such information was requested again,
it should end up in a different spot. Something we could imagine post 3.1 is to
precache this information directly into Java elements (pre/partially initialized
element infos), and hiding the complexity to clients who could blindly trust the
elements to reflect reality.
Comment 1 Jerome Lanneluc CLA 2005-05-02 07:50:55 EDT 
Erich (or Jeem), can you please approve the removal of the 2 APIs ?
- BindingKey#getDeclaringTypeSignature()
- BindingKey#toSignature()
Comment 2 Jim des Rivieres CLA 2005-05-02 08:45:15 EDT 
API change approved

I see there are references to toSignature() in jdt.ui

Please coordinate jdt.core and jdt.ui release to HEAD today (i.e., skip the 
deprecate), in time for our first nightly integration build.
Comment 3 Jerome Lanneluc CLA 2005-05-02 09:33:42 EDT 
Thanks Jim. 
Removed BindingKey#getDeclaringTypeSignature().
Added BindingKey#internalToSignature() to be used by JDT Core.
Temporary deprecated BindingKey#toSignature().

Dirk or Martin, please make the change asap so that I can remove toSignature()
for tonight's build.
Comment 4 Dirk Baeumer CLA 2005-05-02 12:43:34 EDT 
Talked to Jerome, and we have to remove the flags from the binding key first.
Otherwise I can't compute keys again. Coordinated the release of this with
Jerome for tomorrow.
Comment 5 Jerome Lanneluc CLA 2005-05-03 06:50:27 EDT 
Flags have been removed from binding keys in HEAD.
Comment 6 Dirk Baeumer CLA 2005-05-03 09:23:51 EDT 
Jerome, I have adapted the JDT/UI code to it.
Comment 7 Jerome Lanneluc CLA 2005-05-08 04:44:59 EDT 
Thanks Dirk. Removed BindingKey#toSignature().
Comment 8 Frederic Fusier CLA 2005-05-12 11:20:05 EDT 
Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD.