Bug 92906 - showWeaveInfo for declare annotations
Summary: showWeaveInfo for declare annotations
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 1.5.0 M3   Edit
Assignee: Andrew J Huff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-27 09:55 EDT by Andrew J Huff CLA
Modified: 2005-05-06 08:43 EDT (History)
0 users

See Also:

Attachments
Patches to make showweaveinfo work (3.01 KB, application/octet-stream)
2005-05-03 08:32 EDT, Andrew Clement CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew J Huff CLA 2005-04-27 09:55:33 EDT 
declaring annotations (declare @type, @constructor, @method and @field)
currently doesn't show a message when the -showWeaveInfo option is set in ajc.

Appropriate messages should be displayed.
Comment 1 Andrew Clement CLA 2005-05-03 05:39:02 EDT 
I have a patch from Andrew, will put this in for 1.5.0M3
Comment 2 Andrew Clement CLA 2005-05-03 08:32:46 EDT 
Created attachment 20630 [details]
Patches to make showweaveinfo work

This includes the patch to make -showWeaveInfo work for declare @type, field,
method, ctor.  But I don't think it copes with null source locations (see the
beautifyLocation() method in the Shadow class) - which can occur when no debug
info exists for the types being woven.
Comment 3 Andrew Clement CLA 2005-05-04 05:25:24 EDT 
Patch integrated.  I tidied up the code so there wasn't the possibility of
multiple NPEs occurring per line.  I modified it to cope with duff source
location (i.e. when no debug information is present) and I changed the weaving
message so that it reports what annotation is being attached to each member/type.

Fix will be in next dev build.
Comment 4 Andrew Clement CLA 2005-05-06 08:43:11 EDT 
Fix available, see AspectJ download page:
aspectj-DEVELOPMENT-20050506112715.jar