Bug 9261 - Decorators cause eager plugin activation
Summary: Decorators cause eager plugin activation
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 major (vote)
Target Milestone: 2.0 F3   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-02-07 12:34 EST by John Arthorne CLA
Modified: 2002-06-05 12:01 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2002-02-07 12:34:38 EST
Build 20020205

If you open a brand new workspace in this build, the debug.core and debug.ui 
plugins get activated eagerly.  This is because they register a label decorator 
that is turned on by default.  Maybe this is fine, but I thought I should point 
it out.  One possible solution is to always have decorators turned off by 
default, and it would be up to the user to decide if they want them turned on 
(or they could be turned on implicitly by the first launch/debug attempt).  This 
would be more in line with the "user controlled activation" philosophy of 
eclipse.
Comment 1 Nick Edgar CLA 2002-02-27 23:05:15 EST
Although this was supposed to have been fixed, I believe I still saw this 
occurring in the 20020214 build, while tracing class loading in a self-hosting 
workspace (not an empty workspace).
Please investigate.
Comment 2 Tod Creasey CLA 2002-03-07 13:12:54 EST
In build 20020203 sing Optimize it the only plugin outside of org.eclipse.ui 
and its prerequisites that gets loaded is the vcm plugin as it is used to build 
the Repositories View.

When you enable the Binary Projects Decorator the debug plugin gets activated 
as expected.
Comment 3 John Arthorne CLA 2002-06-03 13:59:22 EDT
Now in build 20020602 (Freeze 2).

Decorators are still causing eager plugin activation.  Now, the PDE decorator is 
turned on by default, but the same arguments apply.  I think it should be always 
off by default, then the PDE plugin could turn them on when it starts up if 
desired.  Turn on the following in the .options file:

org.eclipse.core.runtime/debug=true
org.eclipse.core.runtime/timing/startup=true

And you will see the following when opening a new workspace:

Starting plugin: org.eclipse.pde.ui
Starting plugin: org.eclipse.pde.core
Starting plugin: org.eclipse.jdt.core
Finished plugin startup for org.eclipse.jdt.core time: 500ms
Finished plugin startup for org.eclipse.pde.core time: 882ms
Finished plugin startup for org.eclipse.pde.ui time: 1082ms

It looks like we could chop a couple of seconds off our empty workspace startup 
time by changing this behaviour...
Comment 4 John Arthorne CLA 2002-06-03 14:00:07 EDT
Moving back to Nick for triage/evaluation
Comment 5 Tod Creasey CLA 2002-06-03 14:04:42 EDT
Any plugin that turns on a decorator bu default will cause plug-in activation - 
this is more of a PDE issue.
Comment 6 Nick Edgar CLA 2002-06-03 14:30:20 EDT
We need to allow decorators to be on by default for certain customer scenarios.
However, I think the PDE decorator should be off by default to avoid starting 
PDE.
Dejan, can you turn it off so we gain some startup time? 
Comment 7 Dejan Glozic CLA 2002-06-03 14:32:53 EDT
Makes sense. I thought that the attribute was not going to be honoured. Looks 
like it is not the case.
Comment 8 Nick Edgar CLA 2002-06-03 14:42:36 EDT
We had to add back support for turning decorators on by default since a 
particular version provider requires them.
Comment 9 Dejan Glozic CLA 2002-06-04 19:51:34 EDT
F3 candidate.
Comment 10 Dejan Glozic CLA 2002-06-05 12:01:34 EDT
Fixed.