Bug 92369 - [implementation] Closing JavaEditor: 93% spend in SemanticHighlightingManager
Summary: [implementation] Closing JavaEditor: 93% spend in SemanticHighlightingManager
Status: RESOLVED WORKSFORME
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-04-22 09:49 EDT by Martin Aeschlimann CLA
Modified: 2005-04-27 07:21 EDT (History)
0 users

See Also:


Attachments
method invocation times (175.88 KB, text/html)
2005-04-22 09:50 EDT, Martin Aeschlimann CLA
no flags Details
method invocation trace using I20050426-1700 (152.59 KB, text/html)
2005-04-27 03:57 EDT, Martin Aeschlimann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2005-04-22 09:49:22 EDT
20040420 with jdt.ui/text and jdt.core in HEAD

- Copy OS.java from swt.win32 to a new project (-> lot's of compile errors)
- Open this new file and close it again
Comment 1 Martin Aeschlimann CLA 2005-04-22 09:50:06 EDT
Created attachment 20237 [details]
method invocation times
Comment 2 Dani Megert CLA 2005-04-22 10:01:11 EDT
The dispose life-cycle is broken in this week's I-build, see bug 92019.

So either we wait for the next I-build or use an N-build for investigation.
Comment 3 Dani Megert CLA 2005-04-26 16:18:18 EDT
Martin, is it still slow for you using I20050426-0849?
Ensure that this is the only open editor otherwise you mess up the numbers i.e.
what's spent in SemanticHighlightingManager might be for the editor that gets
activated and not for the one that's being closed.
Comment 4 Martin Aeschlimann CLA 2005-04-27 03:55:24 EDT
problem is still there

- make sure that the file is opened in a source editor and contains lots of error
- make sure that semantic highlighting has been applied to the editor

in my runtime workbench it takes around 6 seconds to close that editor
Comment 5 Martin Aeschlimann CLA 2005-04-27 03:57:13 EDT
Created attachment 20392 [details]
method invocation trace using I20050426-1700
Comment 6 Martin Aeschlimann CLA 2005-04-27 07:21:14 EDT
false alarm, I was not on I20050426-1700

In I20050426-1700 the problem is solved!