Bug 91768 - ProblemsLabelDecorator.getErrorTicks takes 9% of time to open a large editor
Summary: ProblemsLabelDecorator.getErrorTicks takes 9% of time to open a large editor
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-04-18 14:20 EDT by Tod Creasey CLA
Modified: 2005-05-03 09:44 EDT (History)
0 users

See Also:

Attachments
Profile output (211.05 KB, text/html)
2005-04-18 14:21 EDT, Tod Creasey CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2005-04-18 14:20:35 EDT 
20050413

When you open a java editor on org.eclipse.swt.internal.win32.OS 9% of the time
to open (934ms in my profile) was taken in ProblemsLabelDecorator.getErrorTicks.
This is 20% of the time to open the outline.

STEPS
1) Reset the java perspective
2) Open  org.eclipse.swt.internal.win32.OS

Trace to follow
Comment 1 Tod Creasey CLA 2005-04-18 14:21:24 EDT 
Created attachment 20009 [details]
Profile output
Comment 2 Dirk Baeumer CLA 2005-04-19 04:53:27 EDT 
Martin, can you please investigate.

Tod, why does this block bug 89406. We haven't change anything here recentlt so
we didn't make it worth.
Comment 3 Tod Creasey CLA 2005-04-19 07:43:30 EDT 
My performance tests are failing for the open/close editor (since 3.0) which is
Bug 89406 so I added all of the bugs to do with open/close as prereqs for the tests.

If there was a way for me to mark something as related rather than blocking  I
would have done that - I just want to keep the connection well defined.
Comment 4 Martin Aeschlimann CLA 2005-04-21 12:35:29 EDT 
the profile trace ends at the most interesting spot: What are the children of 
org.eclipse.jdt.ui.ProblemsLabelDecorator.getErrorTicksFromWorkingCopy()?

I tried to reproduce but coudn't. Do you have errors on the file or any other
markers?
Comment 5 Tod Creasey CLA 2005-04-21 13:41:38 EDT 
No - no errors. I'll see if nay can go any further.

Note this is with last builds build and you guys may have already fixed this.
Comment 6 Tod Creasey CLA 2005-05-02 13:20:47 EDT 
This is not a problem in the current profiles I am taking. Feel free to close
this as FIXED.
Comment 7 Martin Aeschlimann CLA 2005-05-03 03:05:26 EDT 
in fact I made some improvements on error ticks. I wanted to annotate that in
this bug but I forgot