Bug 91709 - [1.5][model] Quick Fix Error but no Problem Reported
Summary: [1.5][model] Quick Fix Error but no Problem Reported
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 143516 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-17 23:56 EDT by Terry Corbet CLA
Modified: 2006-09-12 08:59 EDT (History)
1 user (show)

See Also:


Attachments
Testcase (1.30 KB, application/octet-stream)
2005-04-18 12:53 EDT, Terry Corbet CLA
no flags Details
Proposed patch and regression test (2.99 KB, patch)
2006-05-12 10:18 EDT, Jerome Lanneluc CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Corbet CLA 2005-04-17 23:56:08 EDT
Perhaps this is just a learning curve issue, but it seems like a solid bug.

I have Java 5 code involving sub-classing of a base class which I have
'genericized'.  To simplify matters, I have added a main for testing.

If I go through the run-launch sequence, no Problems are reported and the code
executes as expected.  However, in the editor view of the source code I have a
half-dozen lines flagged with the light-bulb plus red-x combination.  I don't
know what I am supposed to call those icons, but whatever they are called, they
'shout' that something is wrong along with accompanying text and even suggested
corrective actions.

I've spent a lot of hours trying to eliminate the errors, including pulling the
code out of Eclipse and running stand-alone tests switching between the 'modern'
compiler and the external invocation of the Eclipse-internal compiler.  In those
modes, again, the code compiles absolutely cleanly and executes with the
expected results.

Of course, you will want me to send the exact error messages and even the sample
code, but this seems like a general problem that must show up in many, many
places irrespective of the specific diagnostic error -- or at least with any 1.5
code using generics.  So, before cluttering things up with all the details, I'm
hoping someone can point me to some previously-reported bug and the fix.  The
general symptom might be classified as "when is there a difference between
diagnostic errors as reported in an editor view and diagnostic errors reported
in the problem view"?
Comment 1 Philipe Mulet CLA 2005-04-18 04:13:29 EDT
I agree this seems inconsistent. You could provide steps to recreate and then
reopen ?
Comment 2 Terry Corbet CLA 2005-04-18 12:52:13 EDT
Ok, I have created as compact a test case as I can.

The test driver should correctly produce four lines of output.
It should show no errors or warnings of any kind in "Problems",
but 1 line in the sub-class and 4 lines in the test driver will
be flagged in the editor views as invalid.
Comment 3 Terry Corbet CLA 2005-04-18 12:53:09 EDT
Created attachment 20005 [details]
Testcase

The jar file contains:
   B a simple abstract base class that encapsulates a object reference.
   S a simple sub-class of B.
   T a stand-alone test driver.
Comment 4 Olivier Thomann CLA 2005-06-07 11:39:39 EDT
Reproduced in HEAD.
If the type parameter $T is renamed in T, all errors are gone.
Comment 5 Philipe Mulet CLA 2006-05-12 06:06:00 EDT
No problem on compiler side. Added GenericTypeTest#test0986.
Issue resides on JavaModel side.
Comment 6 Jerome Lanneluc CLA 2006-05-12 10:18:01 EDT
Created attachment 41310 [details]
Proposed patch and regression test
Comment 7 Jerome Lanneluc CLA 2006-06-19 11:54:37 EDT
*** Bug 143516 has been marked as a duplicate of this bug. ***
Comment 8 Jerome Lanneluc CLA 2006-06-19 12:27:44 EDT
Fix and test released for 3.3M1 in HEAD and released for 3.2.1 in TARGET_321 branch.
Comment 9 Frederic Fusier CLA 2006-08-07 05:05:23 EDT
Verified for 3.3 M1 using build I20060807-0010
Comment 10 Terry Corbet CLA 2006-08-08 02:40:48 EDT
This comment is only provided so that someone, someday, doing a search will come across it.  It needs to be reported that, compared to all the other open source projects we all rely upon, the professional handling by the Eclipse team far exceeds them all.  Probably the folks involved in this fix weren't even born when IBM software engineers were sending out patches to the operating systems for second- and third-generation mainframes, but you can tell that they have inherited from that gene pool.  There's just no substitute for hard work. Thanks.
Comment 11 David Audel CLA 2006-09-12 08:59:59 EDT
Verified for 3.2.1 using build M20060908-1655