Bug 91497 - [prefs] JavaCore should not give access to default preferences
Summary: [prefs] JavaCore should not give access to default preferences
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-15 04:14 EDT by Frederic Fusier CLA
Modified: 2005-05-12 10:16 EDT (History)
2 users (show)

See Also:

Attachments
Patch to remove these publci methods/fields (14.55 KB, patch)
2005-04-15 11:23 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2005-04-15 04:14:27 EDT 
Using public method JavaCore.getDefaultPreferences(), user can erase all
JavaCore default options without any way to reinstall them:

IEclipsePreferences defaultPreferences = JavaCore.getDefaultPreferences();
defaultPreferences.removeNode();

This not correct and definitely must be fixed before 3.1 delivery.
Comment 1 Philipe Mulet CLA 2005-04-15 04:17:30 EDT 
We should remove offending methods from API. Note that these methods are not
used and are not documented as part of the API, simply got added as public
methods on an API class.

Frederic : pls attach suggested patch for PMC consideration
Comment 2 Philipe Mulet CLA 2005-04-15 04:23:35 EDT 
Basically, all internal methods tagged @since 3.1 should go away.
Comment 3 Jim des Rivieres CLA 2005-04-15 10:21:48 EDT 
Is this the full list of JavaCore methods and fields to be deleted from the 
API?
   public static final IEclipsePreferences[] preferencesLookup;
   public static IEclipsePreferences getDefaultPreferences();
   public static IEclipsePreferences getInstancePreferences() {

Please remove them from the API at the earliest possible opportunity. 
(According to my full source ws, there are no reference to any of these 
outside JDT Core.)
Comment 4 Frederic Fusier CLA 2005-04-15 11:23:03 EDT 
Created attachment 19945 [details]
Patch to remove these publci methods/fields

Jeem, I confirm that this is the full list of removed public method and fields
(see patch for more details on implementation)
Comment 5 Jim des Rivieres CLA 2005-04-15 11:33:15 EDT 
Frederic,  Patch looks good. You can release anytime.
Comment 6 Frederic Fusier CLA 2005-04-15 13:30:19 EDT 
Thanks jeem.

Released in HEAD.
Comment 7 Maxime Daniel CLA 2005-05-12 09:51:43 EDT 
Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD.