Bug 91426 - [Markers] Java task tags in Task View don't have configured priority
Summary: [Markers] Java task tags in Task View don't have configured priority
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal with 3 votes (vote)
Target Milestone: 3.1.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 91720 96452 97315 109821 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-14 12:43 EDT by Greg Smith CLA
Modified: 2005-09-26 11:17 EDT (History)
10 users (show)

See Also:

Attachments
Proposed fix (1.62 KB, patch)
2005-07-05 21:31 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (2.72 KB, patch)
2005-07-06 16:51 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Smith CLA 2005-04-14 12:43:45 EDT 
I just switched from 3.1M5 to 3.1M6 and I noticed that High and Low priority
tasks from Java files (configured via
Windows|Preferences|Java|Compiler|Error/Warnings) no longer have their correct
priority in the view. They have no icon specified, which I assume means normal
priority.

Additionally, the tasks are now editable, so I can mark them as completed and
change the description. However, this has no relation to the Java file they
originated from, i.e. it doesn't update the comment text in the .java. I don't
think I would want that anyways, but if compiler-generated tasks are going to be
editable in Task View, they should tie back to the source.

I couldn't find anything in the build notes or help for 3.1m6. I didn't see any
way to configure the editablility of .java tasks -- I liked the m5 style where
java tasks are non-editable in the Task View. When I switched to m6, I reused
the same workspace, but it happens in a new workspace as well.
Comment 1 Dirk Baeumer CLA 2005-04-15 06:22:41 EDT 
The task view is provided by Platform/UI.
Comment 2 Kim Horne CLA 2005-04-17 19:24:26 EDT 
In M6
Comment 3 Christian Schweer (only bugzilla-mails accepted) CLA 2005-05-04 06:02:42 EDT 
Confirming missing priority for 3.1M6 on Windows XP.

I think you meant Windows|Preferences|Java|Compiler|Task Tags ?!

Should we create a new bug for the "editable description" bug and use this bug
to track the priority error?
Comment 4 Christian Schweer (only bugzilla-mails accepted) CLA 2005-05-04 06:08:11 EDT 
see bug 26942 for the editable task description
Comment 5 Philipe Mulet CLA 2005-05-04 06:38:07 EDT 
Should we tag Java tasks as read-only ? Originally, we did so, but then JDT/UI
wanted to be able to associate some quickfix for them (remove).
Comment 6 Philipe Mulet CLA 2005-05-04 06:38:19 EDT 
*** Bug 91720 has been marked as a duplicate of this bug. ***
Comment 7 Christian Schweer (only bugzilla-mails accepted) CLA 2005-05-04 07:07:58 EDT 
created new bug 93632 for the read-only/read-write bug.

Change severity of "this bug" (i.e. the missing priority of Java task tags) to
major?!

As bug 91720 was for Linux, OS should be changed to all.
Comment 8 Thoralf Rickert CLA 2005-06-02 05:04:14 EDT 
See also Bug #96452
Comment 9 David Saff CLA 2005-06-14 06:31:30 EDT 
Any chance this regression will be targeted for fixing in 3.1?
Comment 10 Olivier Thomann CLA 2005-07-05 21:24:10 EDT 
This problem is coming from a bug in the java image builder that doesn't set the
proper value for the priority key in the marker.
It is setting the severity instead of the priority.
I will add a patch that is fixing this issue.
Comment 11 Olivier Thomann CLA 2005-07-05 21:31:12 EDT 
Created attachment 24372 [details]
Proposed fix
Comment 12 Olivier Thomann CLA 2005-07-05 21:32:05 EDT 
*** Bug 97315 has been marked as a duplicate of this bug. ***
Comment 13 Olivier Thomann CLA 2005-07-05 21:43:56 EDT 
Philippe, this might be a good candidate for 3.1.1.
Comment 14 Olivier Thomann CLA 2005-07-05 22:23:37 EDT 
*** Bug 102569 has been marked as a duplicate of this bug. ***
Comment 15 Olivier Thomann CLA 2005-07-06 16:51:17 EDT 
Created attachment 24403 [details]
Proposed fix

This fix is setting both severity and priority for both (problem's and task's
markers).
Comment 16 Nick Edgar CLA 2005-07-07 10:34:24 EDT 
*** Bug 96452 has been marked as a duplicate of this bug. ***
Comment 17 Olivier Thomann CLA 2005-07-08 15:15:43 EDT 
Fixed and released in 3.1 maintenance stream.
Comment 18 Olivier Thomann CLA 2005-07-11 10:48:40 EDT 
Fixed in HEAD.
Regression test is
org.eclipse.jdt.core.tests.builder.BasicBuildTests.testToDoMarker2 in both HEAD
and 3.1. maintenance stream.
Comment 19 Jerome Lanneluc CLA 2005-08-11 09:55:32 EDT 
Verified with 3.2 M1
Comment 20 Olivier Thomann CLA 2005-09-17 13:44:47 EDT 
*** Bug 109821 has been marked as a duplicate of this bug. ***
Comment 21 Maxime Daniel CLA 2005-09-26 11:12:22 EDT 
Verified for 3.1.1 using build M20050923-1430.
Comment 22 Olivier Thomann CLA 2005-09-26 11:17:19 EDT 
Verified.