Bug 90615 - Proposal for boolean
Summary: Proposal for boolean
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-07 10:34 EDT by Leopold Welsch CLA
Modified: 2005-05-12 14:03 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leopold Welsch CLA 2005-04-07 10:34:23 EDT
boolean test;

test= (the proposal should be true/false)

I don't think the request of the status 'test' makes much sense, i.e.

if (test == true) { ....

=> the first part would be very nice to have it.
Comment 1 Philipe Mulet CLA 2005-04-07 11:12:14 EDT
What exactly are you asking for ?
Comment 2 Leopold Welsch CLA 2005-04-07 11:14:59 EDT
what is unclear from the first two lines of the code?
Comment 3 Philipe Mulet CLA 2005-04-07 12:13:08 EDT
What about any other boolean expressions ?
Comment 4 Leopold Welsch CLA 2005-04-07 12:18:02 EDT
That's an idea, but somehow you have to set the boolean to true or false. And I
would say it's #1 task you'll do in a code.

I know, there are other possibilities of setting it, but focusing on the most
use-cases I would say true/false. It's still a proposal, nothing more.

BTW: Since I've developed VB as well, that VB6-IDE has this proposal as default
and I found it most useful! Simple, easy, effective.
Comment 5 Philipe Mulet CLA 2005-04-07 12:34:15 EDT
Ok, so your original request was actually:
true/false should be included on boolean completions (and I agree with best
relevance). 

I was talking about:
boolean test = somePredicate();

I wonder how we missed the obvious true/false case
Comment 6 Leopold Welsch CLA 2005-04-11 03:26:13 EDT
To say it that way:

#1 priority is this true/false. I wonder as well why this obvious issue nobody
thought about ;)

the other assignments is an idea, but I guess too much about it. cause you could
easily extend it to non-boolean like integer and then it get's complicated.
Except somebody has an clear idea about what could be.
Comment 7 David Audel CLA 2005-04-18 10:53:03 EDT
Fixed and test added
  CompletionTests#testCompletionKeywordTrue5()
  CompletionTests#testCompletionKeywordTrue6()

true or false were already proposed but relevance computation was not complete.
They are not only keywords, they are also boolean expressions.
Comment 8 Olivier Thomann CLA 2005-05-12 14:03:54 EDT
Verified in I20050510-0010 + JDT/Core v_556