Bug 90446 - Update CreateTypeMemberOperation for changes in Indents
Summary: Update CreateTypeMemberOperation for changes in Indents
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-06 09:35 EDT by Martin Aeschlimann CLA
Modified: 2005-05-11 09:58 EDT (History)
2 users (show)

See Also:

Attachments
patch (2.09 KB, application/octet-stream)
2005-04-06 09:36 EDT, Martin Aeschlimann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2005-04-06 09:35:20 EDT 
20050406

I updated Indents to support mixed tab/space indents. Two methods used by
CreateTypeMemberOperation are now deprecated. The following patch brings
CreateTypeMemberOperation up to date.
Comment 1 Martin Aeschlimann CLA 2005-04-06 09:36:43 EDT 
Created attachment 19593 [details]
patch
Comment 2 Jerome Lanneluc CLA 2005-04-06 11:39:08 EDT 
Applying the path, several Java model tests are failing. Can you please 
investigate ?
Comment 3 Martin Aeschlimann CLA 2005-04-06 12:30:11 EDT 
In fact several tests in TypeHierarchyNotificationTest, RenameTests,
SortCompilationUnitElementsTests and CopyMoveElementsTests are failing. But it
seems that my changes have surfaced a bug at a different place:
An assertion is thrown as the option
DefaultCodeFormatterConstants.FORMATTER_TAB_CHAR was not found in the options
returned by JavaCore.getOptions().
When setting a breakpoint in JavaCore.getOptions ASTRewriteFormatter, line 134
you can see that only 5 options are returned

Maybe it would better to not have an assert there, but at least this helped
finding this bug. Let me know if I should remove it for now and tolerate the
missing option.

BTW: Jerome, not related to the bug, but note that CreateElementInCUOperation
line 95 would better not pass null as options but take the options from the
current IJavaProject.
Comment 4 Jerome Lanneluc CLA 2005-04-06 13:31:28 EDT 
Yes please remove your changes so that we don't break the nightly build.
Comment 5 Martin Aeschlimann CLA 2005-04-07 04:40:46 EDT 
filed bug 90580 for the missing options from JavaCore.getOptions
Comment 6 Jerome Lanneluc CLA 2005-04-07 06:45:53 EDT 
Applied patch.
Comment 7 Frederic Fusier CLA 2005-05-11 09:58:13 EDT 
Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD.